diff options
| author | Heikki Linnakangas <heikki.linnakangas@iki.fi> | 2008-11-19 10:34:52 +0000 |
|---|---|---|
| committer | Heikki Linnakangas <heikki.linnakangas@iki.fi> | 2008-11-19 10:34:52 +0000 |
| commit | 3396000684b41e7e9467d1abc67152b39e697035 (patch) | |
| tree | c8edf238f89cd7b0b1562b919f2addebc67eb54e /src/backend/rewrite/rewriteDefine.c | |
| parent | 26e6c896c946bc1a9e9f608b2c7463be1e8c6291 (diff) | |
Rethink the way FSM truncation works. Instead of WAL-logging FSM
truncations in FSM code, call FreeSpaceMapTruncateRel from smgr_redo. To
make that cleaner from modularity point of view, move the WAL-logging one
level up to RelationTruncate, and move RelationTruncate and all the
related WAL-logging to new src/backend/catalog/storage.c file. Introduce
new RelationCreateStorage and RelationDropStorage functions that are used
instead of calling smgrcreate/smgrscheduleunlink directly. Move the
pending rel deletion stuff from smgrcreate/smgrscheduleunlink to the new
functions. This leaves smgr.c as a thin wrapper around md.c; all the
transactional stuff is now in storage.c.
This will make it easier to add new forks with similar truncation logic,
like the visibility map.
Diffstat (limited to 'src/backend/rewrite/rewriteDefine.c')
| -rw-r--r-- | src/backend/rewrite/rewriteDefine.c | 15 |
1 files changed, 3 insertions, 12 deletions
diff --git a/src/backend/rewrite/rewriteDefine.c b/src/backend/rewrite/rewriteDefine.c index 6212add6bcb..2df21b5e355 100644 --- a/src/backend/rewrite/rewriteDefine.c +++ b/src/backend/rewrite/rewriteDefine.c @@ -8,7 +8,7 @@ * * * IDENTIFICATION - * $PostgreSQL: pgsql/src/backend/rewrite/rewriteDefine.c,v 1.132 2008/11/09 21:24:32 tgl Exp $ + * $PostgreSQL: pgsql/src/backend/rewrite/rewriteDefine.c,v 1.133 2008/11/19 10:34:52 heikki Exp $ * *------------------------------------------------------------------------- */ @@ -19,13 +19,13 @@ #include "catalog/indexing.h" #include "catalog/namespace.h" #include "catalog/pg_rewrite.h" +#include "catalog/storage.h" #include "miscadmin.h" #include "nodes/nodeFuncs.h" #include "parser/parse_utilcmd.h" #include "rewrite/rewriteDefine.h" #include "rewrite/rewriteManip.h" #include "rewrite/rewriteSupport.h" -#include "storage/smgr.h" #include "utils/acl.h" #include "utils/builtins.h" #include "utils/inval.h" @@ -484,16 +484,7 @@ DefineQueryRewrite(char *rulename, * XXX what about getting rid of its TOAST table? For now, we don't. */ if (RelisBecomingView) - { - ForkNumber forknum; - - RelationOpenSmgr(event_relation); - for (forknum = 0; forknum <= MAX_FORKNUM; forknum++) - if (smgrexists(event_relation->rd_smgr, forknum)) - smgrscheduleunlink(event_relation->rd_smgr, forknum, - event_relation->rd_istemp); - RelationCloseSmgr(event_relation); - } + RelationDropStorage(event_relation); /* Close rel, but keep lock till commit... */ heap_close(event_relation, NoLock); |