diff options
| author | Robert Haas <rhaas@postgresql.org> | 2022-08-18 11:09:39 -0400 |
|---|---|---|
| committer | Robert Haas <rhaas@postgresql.org> | 2022-08-18 11:22:48 -0400 |
| commit | 576bb0fc93423890761f77384415936bf61267d3 (patch) | |
| tree | 651508f3f2993381935e3aa887b3fcf770361180 /src/backend/storage/buffer/bufmgr.c | |
| parent | 9c4c22fdfeab86a65fdba9d2fe63879c034001ae (diff) | |
When using the WAL-logged CREATE DATABASE strategy, bulk extend.
This should improve performance, and was suggested by Andres Freund.
Back-patch to v15 to keep the code consistent across branches.
Dilip Kumar
Discussion: http://postgr.es/m/C3458199-FEDD-4356-865A-08DFAA5D4065@anarazel.de
Discussion: http://postgr.es/m/CAFiTN-sJ0vVpJrZ=R5M+g7Tr8=NN4wKOtrqOcDEsfFfnZgivVA@mail.gmail.com
Diffstat (limited to 'src/backend/storage/buffer/bufmgr.c')
| -rw-r--r-- | src/backend/storage/buffer/bufmgr.c | 11 |
1 files changed, 10 insertions, 1 deletions
diff --git a/src/backend/storage/buffer/bufmgr.c b/src/backend/storage/buffer/bufmgr.c index 43d3c8caaa6..8727a50d949 100644 --- a/src/backend/storage/buffer/bufmgr.c +++ b/src/backend/storage/buffer/bufmgr.c @@ -3713,6 +3713,7 @@ RelationCopyStorageUsingBuffer(RelFileNode srcnode, bool use_wal; BlockNumber nblocks; BlockNumber blkno; + PGAlignedBlock buf; BufferAccessStrategy bstrategy_src; BufferAccessStrategy bstrategy_dst; @@ -3731,6 +3732,14 @@ RelationCopyStorageUsingBuffer(RelFileNode srcnode, if (nblocks == 0) return; + /* + * Bulk extend the destination relation of the same size as the source + * relation before starting to copy block by block. + */ + memset(buf.data, 0, BLCKSZ); + smgrextend(smgropen(dstnode, InvalidBackendId), forkNum, nblocks - 1, + buf.data, true); + /* This is a bulk operation, so use buffer access strategies. */ bstrategy_src = GetAccessStrategy(BAS_BULKREAD); bstrategy_dst = GetAccessStrategy(BAS_BULKWRITE); @@ -3748,7 +3757,7 @@ RelationCopyStorageUsingBuffer(RelFileNode srcnode, srcPage = BufferGetPage(srcBuf); /* Use P_NEW to extend the destination relation. */ - dstBuf = ReadBufferWithoutRelcache(dstnode, forkNum, P_NEW, + dstBuf = ReadBufferWithoutRelcache(dstnode, forkNum, blkno, RBM_NORMAL, bstrategy_dst, permanent); LockBuffer(dstBuf, BUFFER_LOCK_EXCLUSIVE); |