diff options
| author | Tom Lane <tgl@sss.pgh.pa.us> | 2004-01-26 22:35:32 +0000 |
|---|---|---|
| committer | Tom Lane <tgl@sss.pgh.pa.us> | 2004-01-26 22:35:32 +0000 |
| commit | c77f363384c3f4a6bbc73f501d2459e94382a30b (patch) | |
| tree | c722b460526c687c1ec9c546aed71b52fbcb3cc4 /src/backend/storage/freespace/freespace.c | |
| parent | e0707cbae9cb5360cd044231fda921fffe8095c5 (diff) | |
Ensure that close() and fclose() are checked for errors, at least in
cases involving writes. Per recent discussion about the possibility
of close-time failures on some filesystems. There is a TODO item for
this, too.
Diffstat (limited to 'src/backend/storage/freespace/freespace.c')
| -rw-r--r-- | src/backend/storage/freespace/freespace.c | 9 |
1 files changed, 7 insertions, 2 deletions
diff --git a/src/backend/storage/freespace/freespace.c b/src/backend/storage/freespace/freespace.c index 20f21866295..3c149c3510b 100644 --- a/src/backend/storage/freespace/freespace.c +++ b/src/backend/storage/freespace/freespace.c @@ -8,7 +8,7 @@ * Portions Copyright (c) 1994, Regents of the University of California * * IDENTIFICATION - * $PostgreSQL: pgsql/src/backend/storage/freespace/freespace.c,v 1.29 2004/01/11 03:49:31 momjian Exp $ + * $PostgreSQL: pgsql/src/backend/storage/freespace/freespace.c,v 1.30 2004/01/26 22:35:32 tgl Exp $ * * * NOTES: @@ -793,7 +793,12 @@ DumpFreeSpaceMap(int code, Datum arg) /* Clean up */ LWLockRelease(FreeSpaceLock); - FreeFile(fp); + if (FreeFile(fp)) + { + elog(LOG, "could not write \"%s\": %m", cachefilename); + /* Remove busted cache file */ + unlink(cachefilename); + } return; |