diff options
| author | Tom Lane <tgl@sss.pgh.pa.us> | 2003-09-24 18:54:02 +0000 |
|---|---|---|
| committer | Tom Lane <tgl@sss.pgh.pa.us> | 2003-09-24 18:54:02 +0000 |
| commit | a56a016ceb612cdee1ddc5990682f36d541e5b07 (patch) | |
| tree | c496319424e0445562dd42ee7229e6d87567996f /src/backend/storage/ipc | |
| parent | 5f78c6a886a22209dee62de0c13edd6a68453011 (diff) | |
Repair some REINDEX problems per recent discussions. The relcache is
now able to cope with assigning new relfilenode values to nailed-in-cache
indexes, so they can be reindexed using the fully crash-safe method. This
leaves only shared system indexes as special cases. Remove the 'index
deactivation' code, since it provides no useful protection in the shared-
index case. Require reindexing of shared indexes to be done in standalone
mode, but remove other restrictions on REINDEX. -P (IgnoreSystemIndexes)
now prevents using indexes for lookups, but does not disable index updates.
It is therefore safe to allow from PGOPTIONS. Upshot: reindexing system catalogs
can be done without a standalone backend for all cases except
shared catalogs.
Diffstat (limited to 'src/backend/storage/ipc')
| -rw-r--r-- | src/backend/storage/ipc/sinval.c | 8 |
1 files changed, 7 insertions, 1 deletions
diff --git a/src/backend/storage/ipc/sinval.c b/src/backend/storage/ipc/sinval.c index edd12ed5c84..366a606684a 100644 --- a/src/backend/storage/ipc/sinval.c +++ b/src/backend/storage/ipc/sinval.c @@ -8,7 +8,7 @@ * * * IDENTIFICATION - * $Header: /cvsroot/pgsql/src/backend/storage/ipc/sinval.c,v 1.59 2003/08/04 02:40:03 momjian Exp $ + * $Header: /cvsroot/pgsql/src/backend/storage/ipc/sinval.c,v 1.60 2003/09/24 18:54:01 tgl Exp $ * *------------------------------------------------------------------------- */ @@ -73,6 +73,12 @@ SendSharedInvalidMessage(SharedInvalidationMessage *msg) /* * ReceiveSharedInvalidMessages * Process shared-cache-invalidation messages waiting for this backend + * + * NOTE: it is entirely possible for this routine to be invoked recursively + * as a consequence of processing inside the invalFunction or resetFunction. + * Hence, we must be holding no SI resources when we call them. The only + * bad side-effect is that SIDelExpiredDataEntries might be called extra + * times on the way out of a nested call. */ void ReceiveSharedInvalidMessages( |