summaryrefslogtreecommitdiff
path: root/src/backend/utils/adt/acl.c
diff options
context:
space:
mode:
authorTom Lane <tgl@sss.pgh.pa.us>2015-03-12 13:38:49 -0400
committerTom Lane <tgl@sss.pgh.pa.us>2015-03-12 13:38:49 -0400
commit4a4fd2b0ceedb339118b0cf10ca78e472ce20a90 (patch)
tree3d09e27a23605d84f084a55b349865873fd7698e /src/backend/utils/adt/acl.c
parent92bb008d8b62fe38c0272a43628b2ae22682c512 (diff)
Ensure tableoid reads correctly in EvalPlanQual-manufactured tuples.
The ROW_MARK_COPY path in EvalPlanQualFetchRowMarks() was just setting tableoid to InvalidOid, I think on the assumption that the referenced RTE must be a subquery or other case without a meaningful OID. However, foreign tables also use this code path, and they do have meaningful table OIDs; so failure to set the tuple field can lead to user-visible misbehavior. Fix that by fetching the appropriate OID from the range table. There's still an issue about whether CTID can ever have a meaningful value in this case; at least with postgres_fdw foreign tables, it does. But that is a different problem that seems to require a significantly different patch --- it's debatable whether postgres_fdw really wants to use this code path at all. Simplified version of a patch by Etsuro Fujita, who also noted the problem to begin with. The issue can be demonstrated in all versions having FDWs, so back-patch to 9.1.
Diffstat (limited to 'src/backend/utils/adt/acl.c')
0 files changed, 0 insertions, 0 deletions