diff options
| author | Tom Lane <tgl@sss.pgh.pa.us> | 2018-10-06 13:18:38 -0400 |
|---|---|---|
| committer | Tom Lane <tgl@sss.pgh.pa.us> | 2018-10-06 13:18:38 -0400 |
| commit | 0209f0285d9b1c60bf74cc9f5f0133d7bdd887c3 (patch) | |
| tree | 3a06f8ea9866344a00161bc1f0e3a357e6402646 /src/backend/utils/adt/formatting.c | |
| parent | 07ee62ce9e507c14632c0517aeeae4e60b0d1997 (diff) | |
Don't use is_infinite() where isinf() will do.
Places that aren't testing for sign should not use the more expensive
function; it's just wasteful, not to mention being a cognitive load
for readers who may know what isinf() is but not is_infinite().
As things stand, we actually don't need is_infinite() anyplace except
float4out/float8out, which means it could potentially go away altogether
after the changes I proposed in <13178.1538794717@sss.pgh.pa.us>.
Diffstat (limited to 'src/backend/utils/adt/formatting.c')
| -rw-r--r-- | src/backend/utils/adt/formatting.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/backend/utils/adt/formatting.c b/src/backend/utils/adt/formatting.c index 0ed59f1c347..5d472d01133 100644 --- a/src/backend/utils/adt/formatting.c +++ b/src/backend/utils/adt/formatting.c @@ -5731,7 +5731,7 @@ float4_to_char(PG_FUNCTION_ARGS) numstr = orgnum = int_to_roman((int) rint(value)); else if (IS_EEEE(&Num)) { - if (isnan(value) || is_infinite(value)) + if (isnan(value) || isinf(value)) { /* * Allow 6 characters for the leading sign, the decimal point, @@ -5835,7 +5835,7 @@ float8_to_char(PG_FUNCTION_ARGS) numstr = orgnum = int_to_roman((int) rint(value)); else if (IS_EEEE(&Num)) { - if (isnan(value) || is_infinite(value)) + if (isnan(value) || isinf(value)) { /* * Allow 6 characters for the leading sign, the decimal point, |