summaryrefslogtreecommitdiff
path: root/src/backend/utils/cache/catcache.c
diff options
context:
space:
mode:
authorNoah Misch <noah@leadboat.com>2024-11-02 09:05:00 -0700
committerNoah Misch <noah@leadboat.com>2024-11-02 09:05:07 -0700
commitfe8091c9e39e65c8a0044349f0c0e7c3386ae921 (patch)
tree29fcb09b214fac387cf1a7c0556008894aca60b9 /src/backend/utils/cache/catcache.c
parentbe74b943c92054baa701f3aa5d789c09e3d914d8 (diff)
Revert "For inplace update, send nontransactional invalidations."
This reverts commit 95c5acb3fc261067ab65ddc0b2dca8e162f09442 (v17) and counterparts in each other non-master branch. If released, that commit would have caused a worst-in-years minor release regression, via undetected LWLock self-deadlock. This commit and its self-deadlock fix warrant more bake time in the master branch. Reported by Alexander Lakhin. Discussion: https://postgr.es/m/10ec0bc3-5933-1189-6bb8-5dec4114558e@gmail.com
Diffstat (limited to 'src/backend/utils/cache/catcache.c')
-rw-r--r--src/backend/utils/cache/catcache.c7
1 files changed, 3 insertions, 4 deletions
diff --git a/src/backend/utils/cache/catcache.c b/src/backend/utils/cache/catcache.c
index 9a6189004d9..b53232f6278 100644
--- a/src/backend/utils/cache/catcache.c
+++ b/src/backend/utils/cache/catcache.c
@@ -2129,8 +2129,7 @@ void
PrepareToInvalidateCacheTuple(Relation relation,
HeapTuple tuple,
HeapTuple newtuple,
- void (*function) (int, uint32, Oid, void *),
- void *context)
+ void (*function) (int, uint32, Oid))
{
slist_iter iter;
Oid reloid;
@@ -2171,7 +2170,7 @@ PrepareToInvalidateCacheTuple(Relation relation,
hashvalue = CatalogCacheComputeTupleHashValue(ccp, ccp->cc_nkeys, tuple);
dbid = ccp->cc_relisshared ? (Oid) 0 : MyDatabaseId;
- (*function) (ccp->id, hashvalue, dbid, context);
+ (*function) (ccp->id, hashvalue, dbid);
if (newtuple)
{
@@ -2180,7 +2179,7 @@ PrepareToInvalidateCacheTuple(Relation relation,
newhashvalue = CatalogCacheComputeTupleHashValue(ccp, ccp->cc_nkeys, newtuple);
if (newhashvalue != hashvalue)
- (*function) (ccp->id, newhashvalue, dbid, context);
+ (*function) (ccp->id, newhashvalue, dbid);
}
}
}