diff options
| author | Peter Eisentraut <peter@eisentraut.org> | 2024-03-04 12:00:11 +0100 |
|---|---|---|
| committer | Peter Eisentraut <peter@eisentraut.org> | 2024-03-04 12:02:20 +0100 |
| commit | dbbca2cf299b81299112ca6ada671a36235ec008 (patch) | |
| tree | aac5368f0983f682c6a31b6bc6140cd89b50fe3c /src/backend/utils/sort | |
| parent | 24eebc65c26cfcc0ea5b8a95b61fa2fda6118e68 (diff) | |
Remove unused #include's from backend .c files
as determined by include-what-you-use (IWYU)
While IWYU also suggests to *add* a bunch of #include's (which is its
main purpose), this patch does not do that. In some cases, a more
specific #include replaces another less specific one.
Some manual adjustments of the automatic result:
- IWYU currently doesn't know about includes that provide global
variable declarations (like -Wmissing-variable-declarations), so
those includes are being kept manually.
- All includes for port(ability) headers are being kept for now, to
play it safe.
- No changes of catalog/pg_foo.h to catalog/pg_foo_d.h, to keep the
patch from exploding in size.
Note that this patch touches just *.c files, so nothing declared in
header files changes in hidden ways.
As a small example, in src/backend/access/transam/rmgr.c, some IWYU
pragma annotations are added to handle a special case there.
Discussion: https://www.postgresql.org/message-id/flat/af837490-6b2f-46df-ba05-37ea6a6653fc%40eisentraut.org
Diffstat (limited to 'src/backend/utils/sort')
| -rw-r--r-- | src/backend/utils/sort/sharedtuplestore.c | 1 | ||||
| -rw-r--r-- | src/backend/utils/sort/sortsupport.c | 1 | ||||
| -rw-r--r-- | src/backend/utils/sort/tuplesort.c | 3 |
3 files changed, 0 insertions, 5 deletions
diff --git a/src/backend/utils/sort/sharedtuplestore.c b/src/backend/utils/sort/sharedtuplestore.c index 6a5817b5135..137476a7a77 100644 --- a/src/backend/utils/sort/sharedtuplestore.c +++ b/src/backend/utils/sort/sharedtuplestore.c @@ -23,7 +23,6 @@ #include "access/htup.h" #include "access/htup_details.h" -#include "miscadmin.h" #include "storage/buffile.h" #include "storage/lwlock.h" #include "storage/sharedfileset.h" diff --git a/src/backend/utils/sort/sortsupport.c b/src/backend/utils/sort/sortsupport.c index 14d499af926..c8a75487a3a 100644 --- a/src/backend/utils/sort/sortsupport.c +++ b/src/backend/utils/sort/sortsupport.c @@ -17,7 +17,6 @@ #include "access/gist.h" #include "access/nbtree.h" -#include "catalog/pg_am.h" #include "fmgr.h" #include "utils/lsyscache.h" #include "utils/rel.h" diff --git a/src/backend/utils/sort/tuplesort.c b/src/backend/utils/sort/tuplesort.c index 97e8f93b93e..f50a9c1a8e7 100644 --- a/src/backend/utils/sort/tuplesort.c +++ b/src/backend/utils/sort/tuplesort.c @@ -101,15 +101,12 @@ #include <limits.h> -#include "catalog/pg_am.h" #include "commands/tablespace.h" -#include "executor/executor.h" #include "miscadmin.h" #include "pg_trace.h" #include "storage/shmem.h" #include "utils/memutils.h" #include "utils/pg_rusage.h" -#include "utils/rel.h" #include "utils/tuplesort.h" /* |