diff options
| author | Noah Misch <noah@leadboat.com> | 2020-05-13 20:42:09 -0700 |
|---|---|---|
| committer | Noah Misch <noah@leadboat.com> | 2020-05-13 20:42:37 -0700 |
| commit | a267894529b260002cdb85cde9680529ae4ceeb4 (patch) | |
| tree | 32721ea1d1c57846bef3494a3c93695fbcf6e844 /src/bin/pg_basebackup/pg_recvlogical.c | |
| parent | 357012e17f3f7d47bd276d4441c28fbcd58a2c8b (diff) | |
Fix pg_recvlogical avoidance of superfluous Standby Status Update.
The defect suppressed a Standby Status Update message when bytes flushed
to disk had changed but bytes received had not changed. If
pg_recvlogical then exited with no intervening Standby Status Update,
the next pg_recvlogical repeated already-flushed records. The defect
could also cause superfluous messages, which are functionally harmless.
Back-patch to 9.5 (all supported versions).
Discussion: https://postgr.es/m/20200502221647.GA3941274@rfd.leadboat.com
Diffstat (limited to 'src/bin/pg_basebackup/pg_recvlogical.c')
| -rw-r--r-- | src/bin/pg_basebackup/pg_recvlogical.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/bin/pg_basebackup/pg_recvlogical.c b/src/bin/pg_basebackup/pg_recvlogical.c index 857b61c8f72..f2fe4c55b2f 100644 --- a/src/bin/pg_basebackup/pg_recvlogical.c +++ b/src/bin/pg_basebackup/pg_recvlogical.c @@ -128,7 +128,7 @@ sendFeedback(PGconn *conn, TimestampTz now, bool force, bool replyRequested) */ if (!force && last_written_lsn == output_written_lsn && - last_fsync_lsn != output_fsync_lsn) + last_fsync_lsn == output_fsync_lsn) return true; if (verbose) |