diff options
| author | Peter Eisentraut <peter@eisentraut.org> | 2022-07-03 20:11:05 +0200 |
|---|---|---|
| committer | Peter Eisentraut <peter@eisentraut.org> | 2022-07-03 20:11:05 +0200 |
| commit | 5faef9d582012433db9ad05af27a77bd591508e1 (patch) | |
| tree | f3ace999fcaf45d69c3eb8428d3afc4819316530 /src/bin/pg_basebackup/streamutil.c | |
| parent | 02c408e21a6e78ff246ea7a1beb4669634fa9c4c (diff) | |
Remove redundant null pointer checks before PQclear and PQconninfoFree
These functions already had the free()-like behavior of handling null
pointers as a no-op. But it wasn't documented, so add it explicitly
to the documentation, too.
Discussion: https://www.postgresql.org/message-id/flat/dac5d2d0-98f5-94d9-8e69-46da2413593d%40enterprisedb.com
Diffstat (limited to 'src/bin/pg_basebackup/streamutil.c')
| -rw-r--r-- | src/bin/pg_basebackup/streamutil.c | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/src/bin/pg_basebackup/streamutil.c b/src/bin/pg_basebackup/streamutil.c index 8e820c0c71c..919ec9c29c2 100644 --- a/src/bin/pg_basebackup/streamutil.c +++ b/src/bin/pg_basebackup/streamutil.c @@ -197,16 +197,14 @@ GetConnection(void) PQfinish(tmpconn); free(values); free(keywords); - if (conn_opts) - PQconninfoFree(conn_opts); + PQconninfoFree(conn_opts); return NULL; } /* Connection ok! */ free(values); free(keywords); - if (conn_opts) - PQconninfoFree(conn_opts); + PQconninfoFree(conn_opts); /* * Set always-secure search path, so malicious users can't get control. |