diff options
| author | Tom Lane <tgl@sss.pgh.pa.us> | 2020-11-06 15:48:21 -0500 |
|---|---|---|
| committer | Tom Lane <tgl@sss.pgh.pa.us> | 2020-11-06 15:48:21 -0500 |
| commit | 9e98ddd16e0623fe3f993fdd6dd032af5be7da6c (patch) | |
| tree | 510a6227c539357757a900edda7c72c87d3a3584 /src/bin/pg_dump/pg_dump.c | |
| parent | 8b4121903c2d7deca4a7041af791ede46597f9dd (diff) | |
Revert "pg_dump: Lock all relations, not just plain tables".
Revert 403a3d91c, as well as the followup fix 7f4235032, in all
branches. We need to think a bit harder about what the behavior
of LOCK TABLE on views should be, and there's no time for that
before next week's releases. We'll take another crack at this
later.
Discussion: https://postgr.es/m/16703-e348f58aab3cf6cc@postgresql.org
Diffstat (limited to 'src/bin/pg_dump/pg_dump.c')
| -rw-r--r-- | src/bin/pg_dump/pg_dump.c | 11 |
1 files changed, 3 insertions, 8 deletions
diff --git a/src/bin/pg_dump/pg_dump.c b/src/bin/pg_dump/pg_dump.c index c886ffefbd0..b30b87ae66d 100644 --- a/src/bin/pg_dump/pg_dump.c +++ b/src/bin/pg_dump/pg_dump.c @@ -1062,9 +1062,6 @@ setup_connection(Archive *AH, const char *dumpencoding, ExecuteSqlStatement(AH, "SET row_security = off"); } - /* Detect whether LOCK TABLE can handle non-table relations */ - AH->hasGenericLockTable = IsLockTableGeneric(AH); - /* * Start transaction-snapshot mode transaction to dump consistent data. */ @@ -5401,12 +5398,10 @@ getTables(Archive *fout, int *numTables) * assume our lock on the child is enough to prevent schema * alterations to parent tables. * - * On server versions that support it, we lock all relations not just - * plain tables. + * NOTE: it'd be kinda nice to lock other relations too, not only + * plain tables, but the backend doesn't presently allow that. */ - if (tblinfo[i].dobj.dump && - (fout->hasGenericLockTable || - tblinfo[i].relkind == RELKIND_RELATION)) + if (tblinfo[i].dobj.dump && tblinfo[i].relkind == RELKIND_RELATION) { resetPQExpBuffer(query); appendPQExpBuffer(query, |