summaryrefslogtreecommitdiff
path: root/src/bin/pg_upgrade/check.c
diff options
context:
space:
mode:
authorHeikki Linnakangas <heikki.linnakangas@iki.fi>2015-07-02 20:58:51 +0300
committerHeikki Linnakangas <heikki.linnakangas@iki.fi>2015-07-02 20:58:51 +0300
commitf712289ffad7c3fb6eb3be4f81adb0aa0981c9f7 (patch)
treef7ebf8219c469284f943be3de66c70ad158e2caf /src/bin/pg_upgrade/check.c
parent1fd0d5ec0373666fe00db4f641490d9e82f53e01 (diff)
Plug some trivial memory leaks in pg_dump and pg_upgrade.
There's no point in trying to free every small allocation in these programs that are used in a one-shot fashion, but these ones seems like an improvement on readability grounds. Michael Paquier, per Coverity report.
Diffstat (limited to 'src/bin/pg_upgrade/check.c')
-rw-r--r--src/bin/pg_upgrade/check.c6
1 files changed, 6 insertions, 0 deletions
diff --git a/src/bin/pg_upgrade/check.c b/src/bin/pg_upgrade/check.c
index 5a91871c359..41d4606dd59 100644
--- a/src/bin/pg_upgrade/check.c
+++ b/src/bin/pg_upgrade/check.c
@@ -337,8 +337,14 @@ equivalent_locale(int category, const char *loca, const char *locb)
lenb = charb ? (charb - canonb) : strlen(canonb);
if (lena == lenb && pg_strncasecmp(canona, canonb, lena) == 0)
+ {
+ pg_free(canona);
+ pg_free(canonb);
return true;
+ }
+ pg_free(canona);
+ pg_free(canonb);
return false;
}