diff options
| author | Bruce Momjian <bruce@momjian.us> | 2015-11-14 11:47:12 -0500 |
|---|---|---|
| committer | Bruce Momjian <bruce@momjian.us> | 2015-11-14 11:47:12 -0500 |
| commit | 025106e314627f5aacdf72fca52ba0ed985d696e (patch) | |
| tree | 701cd93ac4aae65c23801ecb77a684f0ba0acbfe /src/bin/pg_upgrade/file.c | |
| parent | 42aa1c032e3520d608a1e89abbf36409b022d4b7 (diff) | |
pg_upgrade: properly detect file copy failure on Windows
Previously, file copy failures were ignored on Windows due to an
incorrect return value check.
Report by Manu Joye
Backpatch through 9.1
Diffstat (limited to 'src/bin/pg_upgrade/file.c')
| -rw-r--r-- | src/bin/pg_upgrade/file.c | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/src/bin/pg_upgrade/file.c b/src/bin/pg_upgrade/file.c index 79d9390216e..37eb832c93a 100644 --- a/src/bin/pg_upgrade/file.c +++ b/src/bin/pg_upgrade/file.c @@ -34,7 +34,11 @@ copyAndUpdateFile(pageCnvCtx *pageConverter, { if (pageConverter == NULL) { - if (pg_copy_file(src, dst, force) == -1) +#ifndef WIN32 + if (copy_file(src, dst, force) == -1) +#else + if (CopyFile(src, dst, force) == 0) +#endif return getErrorText(errno); else return NULL; |