diff options
| author | Michael Paquier <michael@paquier.xyz> | 2024-03-12 10:02:54 +0900 |
|---|---|---|
| committer | Michael Paquier <michael@paquier.xyz> | 2024-03-12 10:02:54 +0900 |
| commit | 2c8118ee5d980e11f73683fcda2329c323aa381e (patch) | |
| tree | 7527eb2a94bc9cc8821ff9afba62e03918dff351 /src/bin/pg_upgrade/tablespace.c | |
| parent | 3045324214467dd3f0bef31f6f33562b9eb93aa3 (diff) | |
Use printf's %m format instead of strerror(errno) in more places
Most callers of strerror() are removed from the backend code. The
remaining callers require special handling with a saved errno from a
previous system call. The frontend code still needs strerror() where
error states need to be handled outside of fprintf.
Note that pg_regress is not changed to use %m as the TAP output may
clobber errno, since those functions call fprintf() and friends before
evaluating the format string.
Support for %m in src/port/snprintf.c has been added in d6c55de1f99a,
hence all the stable branches currently supported include it.
Author: Dagfinn Ilmari Mannsåker
Discussion: https://postgr.es/m/87sf13jhuw.fsf@wibble.ilmari.org
Diffstat (limited to 'src/bin/pg_upgrade/tablespace.c')
| -rw-r--r-- | src/bin/pg_upgrade/tablespace.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/bin/pg_upgrade/tablespace.c b/src/bin/pg_upgrade/tablespace.c index 46028732197..043e5e721bd 100644 --- a/src/bin/pg_upgrade/tablespace.c +++ b/src/bin/pg_upgrade/tablespace.c @@ -84,8 +84,8 @@ get_tablespace_paths(void) os_info.old_tablespaces[tblnum]); else report_status(PG_FATAL, - "could not stat tablespace directory \"%s\": %s", - os_info.old_tablespaces[tblnum], strerror(errno)); + "could not stat tablespace directory \"%s\": %m", + os_info.old_tablespaces[tblnum]); } if (!S_ISDIR(statBuf.st_mode)) report_status(PG_FATAL, |