summaryrefslogtreecommitdiff
path: root/src/bin/psql/common.c
diff options
context:
space:
mode:
authorPeter Eisentraut <peter@eisentraut.org>2022-07-03 20:11:05 +0200
committerPeter Eisentraut <peter@eisentraut.org>2022-07-03 20:11:05 +0200
commit5faef9d582012433db9ad05af27a77bd591508e1 (patch)
treef3ace999fcaf45d69c3eb8428d3afc4819316530 /src/bin/psql/common.c
parent02c408e21a6e78ff246ea7a1beb4669634fa9c4c (diff)
Remove redundant null pointer checks before PQclear and PQconninfoFree
These functions already had the free()-like behavior of handling null pointers as a no-op. But it wasn't documented, so add it explicitly to the documentation, too. Discussion: https://www.postgresql.org/message-id/flat/dac5d2d0-98f5-94d9-8e69-46da2413593d%40enterprisedb.com
Diffstat (limited to 'src/bin/psql/common.c')
-rw-r--r--src/bin/psql/common.c3
1 files changed, 1 insertions, 2 deletions
diff --git a/src/bin/psql/common.c b/src/bin/psql/common.c
index 974959c5959..9f95869eca6 100644
--- a/src/bin/psql/common.c
+++ b/src/bin/psql/common.c
@@ -463,8 +463,7 @@ ClearOrSaveResult(PGresult *result)
{
case PGRES_NONFATAL_ERROR:
case PGRES_FATAL_ERROR:
- if (pset.last_error_result)
- PQclear(pset.last_error_result);
+ PQclear(pset.last_error_result);
pset.last_error_result = result;
break;