diff options
| author | Daniel Gustafsson <dgustafsson@postgresql.org> | 2022-02-11 20:54:44 +0100 |
|---|---|---|
| committer | Daniel Gustafsson <dgustafsson@postgresql.org> | 2022-02-11 20:54:44 +0100 |
| commit | 549ec201d6132b7c7ee11ee90a4e02119259ba5b (patch) | |
| tree | 44c1669ef24c66233c16b2fa77aff148596f67a7 /src/bin/scripts/t/020_createdb.pl | |
| parent | 751b8d23b788580bbff7463e3959f9a92a95b28a (diff) | |
Replace Test::More plans with done_testing
Rather than doing manual book keeping to plan the number of tests to run
in each TAP suite, conclude each run with done_testing() summing up the
the number of tests that ran. This removes the need for maintaning and
updating the plan count at the expense of an accurate count of remaining
during the test suite runtime.
This patch has been discussed a number of times, often in the context of
other patches which updates tests, so a larger number of discussions can
be found in the archives.
Reviewed-by: Julien Rouhaud <rjuju123@gmail.com>
Reviewed-by: Dagfinn Ilmari Mannsåker <ilmari@ilmari.org>
Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us>
Reviewed-by: Michael Paquier <michael@paquier.xyz>
Reviewed-by: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Discussion: https://postgr.es/m/DD399313-3D56-4666-8079-88949DAC870F@yesql.se
Diffstat (limited to 'src/bin/scripts/t/020_createdb.pl')
| -rw-r--r-- | src/bin/scripts/t/020_createdb.pl | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/src/bin/scripts/t/020_createdb.pl b/src/bin/scripts/t/020_createdb.pl index c54c291b7ad..639245466e8 100644 --- a/src/bin/scripts/t/020_createdb.pl +++ b/src/bin/scripts/t/020_createdb.pl @@ -6,7 +6,7 @@ use warnings; use PostgreSQL::Test::Cluster; use PostgreSQL::Test::Utils; -use Test::More tests => 25; +use Test::More; program_help_ok('createdb'); program_version_ok('createdb'); @@ -75,3 +75,5 @@ $node->command_checks_all( qr/^createdb: error: database creation failed: ERROR: invalid locale name|^createdb: error: database creation failed: ERROR: new LC_CTYPE \(foo'; SELECT '1\) is incompatible with the LC_CTYPE of the template database/s ], 'createdb with incorrect --lc-ctype'); + +done_testing(); |