diff options
| author | Tom Lane <tgl@sss.pgh.pa.us> | 2018-12-26 15:30:10 -0500 |
|---|---|---|
| committer | Tom Lane <tgl@sss.pgh.pa.us> | 2018-12-26 15:30:35 -0500 |
| commit | b8fa4c1626190142d2e98155f9df99f80fe01cef (patch) | |
| tree | 12561f9307e943119eb5a759548465e2a053545c /src/common/psprintf.c | |
| parent | 37126251ab7732a2b047a38571ef8dd9738a5fdf (diff) | |
Fix portability failure introduced in commits d2b0b60e7 et al.
I made a frontend fprintf() format use %m, forgetting that that's only
safe in HEAD not the back branches; prior to 96bf88d52 and d6c55de1f,
it would work on glibc platforms but not elsewhere. Revert to using
%s ... strerror(errno) as the code did before.
We could have left HEAD as-is, but for code consistency across branches,
I chose to apply this patch there too.
Per Coverity and a few buildfarm members.
Diffstat (limited to 'src/common/psprintf.c')
| -rw-r--r-- | src/common/psprintf.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/src/common/psprintf.c b/src/common/psprintf.c index fb66cb14923..00be4aed7d1 100644 --- a/src/common/psprintf.c +++ b/src/common/psprintf.c @@ -131,7 +131,8 @@ pvsnprintf(char *buf, size_t len, const char *fmt, va_list args) #ifndef FRONTEND elog(ERROR, "vsnprintf failed: %m with format string \"%s\"", fmt); #else - fprintf(stderr, "vsnprintf failed: %m with format string \"%s\"\n", fmt); + fprintf(stderr, "vsnprintf failed: %s with format string \"%s\"\n", + strerror(errno), fmt); exit(EXIT_FAILURE); #endif } |