diff options
| author | Noah Misch <noah@leadboat.com> | 2024-10-29 09:39:55 -0700 |
|---|---|---|
| committer | Noah Misch <noah@leadboat.com> | 2024-10-29 09:39:59 -0700 |
| commit | 11e3f288f3dbda8b460aba93e1c18b55017e7b08 (patch) | |
| tree | 0fee1eb5de340af6013a6ac7ec8269a489cb6835 /src/include/access/heapam.h | |
| parent | dedced73e00fc048ba9fbaa5a416b61aebcb42f9 (diff) | |
Unpin buffer before inplace update waits for an XID to end.
Commit a07e03fd8fa7daf4d1356f7cb501ffe784ea6257 changed inplace updates
to wait for heap_update() commands like GRANT TABLE and GRANT DATABASE.
By keeping the pin during that wait, a sequence of autovacuum workers
and an uncommitted GRANT starved one foreground LockBufferForCleanup()
for six minutes, on buildfarm member sarus. Prevent, at the cost of a
bit of complexity. Back-patch to v12, like the earlier commit. That
commit and heap_inplace_lock() have not yet appeared in any release.
Discussion: https://postgr.es/m/20241026184936.ae.nmisch@google.com
Diffstat (limited to 'src/include/access/heapam.h')
| -rw-r--r-- | src/include/access/heapam.h | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/src/include/access/heapam.h b/src/include/access/heapam.h index f5721300560..4a0a856b7cb 100644 --- a/src/include/access/heapam.h +++ b/src/include/access/heapam.h @@ -167,7 +167,8 @@ extern TM_Result heap_lock_tuple(Relation relation, HeapTuple tuple, Buffer *buffer, struct TM_FailureData *tmfd); extern bool heap_inplace_lock(Relation relation, - HeapTuple oldtup_ptr, Buffer buffer); + HeapTuple oldtup_ptr, Buffer buffer, + void (*release_callback) (void *), void *arg); extern void heap_inplace_update_and_unlock(Relation relation, HeapTuple oldtup, HeapTuple tuple, Buffer buffer); |