diff options
author | Tom Lane <tgl@sss.pgh.pa.us> | 2006-01-14 22:03:35 +0000 |
---|---|---|
committer | Tom Lane <tgl@sss.pgh.pa.us> | 2006-01-14 22:03:35 +0000 |
commit | f7ea9312877abcb508669359fa2a05fc69ec91b9 (patch) | |
tree | 5091d2d5bf06da0955d86c20038f9fa7eaf48346 /src/include/access/skey.h | |
parent | 7930e627d8aaf617f4edb8b9e4fe410cc475a93a (diff) |
Some minor code cleanup, falling out from the removal of rtree. SK_NEGATE
isn't being used anywhere anymore, and there seems no point in a generic
index_keytest() routine when two out of three remaining access methods
aren't using it. Also, add a comment documenting a convention for
letting access methods define private flag bits in ScanKey sk_flags.
There are no such flags at the moment but I'm thinking about changing
btree's handling of "required keys" to use flag bits in the keys
rather than a count of required key positions. Also, if some AM did
still want SK_NEGATE then it would be reasonable to treat it as a private
flag bit.
Diffstat (limited to 'src/include/access/skey.h')
-rw-r--r-- | src/include/access/skey.h | 11 |
1 files changed, 8 insertions, 3 deletions
diff --git a/src/include/access/skey.h b/src/include/access/skey.h index 61a8e81a835..f3845e55184 100644 --- a/src/include/access/skey.h +++ b/src/include/access/skey.h @@ -7,7 +7,7 @@ * Portions Copyright (c) 1996-2005, PostgreSQL Global Development Group * Portions Copyright (c) 1994, Regents of the University of California * - * $PostgreSQL: pgsql/src/include/access/skey.h,v 1.29 2005/06/24 00:18:52 tgl Exp $ + * $PostgreSQL: pgsql/src/include/access/skey.h,v 1.30 2006/01/14 22:03:35 tgl Exp $ * *------------------------------------------------------------------------- */ @@ -69,10 +69,15 @@ typedef struct ScanKeyData typedef ScanKeyData *ScanKey; -/* ScanKeyData sk_flags */ +/* + * ScanKeyData sk_flags + * + * sk_flags bits 0-15 are reserved for system-wide use (symbols for those + * bits should be defined here). Bits 16-31 are reserved for use within + * individual index access methods. + */ #define SK_ISNULL 0x0001 /* sk_argument is NULL */ #define SK_UNARY 0x0002 /* unary operator (currently unsupported) */ -#define SK_NEGATE 0x0004 /* must negate the function result */ /* |