diff options
| author | Fujii Masao <fujii@postgresql.org> | 2020-07-20 13:30:18 +0900 |
|---|---|---|
| committer | Fujii Masao <fujii@postgresql.org> | 2020-07-20 13:30:18 +0900 |
| commit | c3fe108c025e4a080315562d4c15ecbe3f00405e (patch) | |
| tree | b70e9db2e58fedb9abd6506574629f1e5ca75386 /src/include/access/xlog.h | |
| parent | 0bead9af484c1d0a67e690fda47011addaa5bc9d (diff) | |
Rename wal_keep_segments to wal_keep_size.
max_slot_wal_keep_size that was added in v13 and wal_keep_segments are
the GUC parameters to specify how much WAL files to retain for
the standby servers. While max_slot_wal_keep_size accepts the number of
bytes of WAL files, wal_keep_segments accepts the number of WAL files.
This difference of setting units between those similar parameters could
be confusing to users.
To alleviate this situation, this commit renames wal_keep_segments to
wal_keep_size, and make users specify the WAL size in it instead of
the number of WAL files.
There was also the idea to rename max_slot_wal_keep_size to
max_slot_wal_keep_segments, in the discussion. But we have been moving
away from measuring in segments, for example, checkpoint_segments was
replaced by max_wal_size. So we concluded to rename wal_keep_segments
to wal_keep_size.
Back-patch to v13 where max_slot_wal_keep_size was added.
Author: Fujii Masao
Reviewed-by: Álvaro Herrera, Kyotaro Horiguchi, David Steele
Discussion: https://postgr.es/m/574b4ea3-e0f9-b175-ead2-ebea7faea855@oss.nttdata.com
Diffstat (limited to 'src/include/access/xlog.h')
| -rw-r--r-- | src/include/access/xlog.h | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/include/access/xlog.h b/src/include/access/xlog.h index d8391aa3783..219a7299e1f 100644 --- a/src/include/access/xlog.h +++ b/src/include/access/xlog.h @@ -107,7 +107,7 @@ extern bool reachedConsistency; extern int wal_segment_size; extern int min_wal_size_mb; extern int max_wal_size_mb; -extern int wal_keep_segments; +extern int wal_keep_size_mb; extern int max_slot_wal_keep_size_mb; extern int XLOGbuffers; extern int XLogArchiveTimeout; @@ -273,7 +273,7 @@ typedef enum WALAvailability WALAVAIL_INVALID_LSN, /* parameter error */ WALAVAIL_RESERVED, /* WAL segment is within max_wal_size */ WALAVAIL_EXTENDED, /* WAL segment is reserved by a slot or - * wal_keep_segments */ + * wal_keep_size */ WALAVAIL_UNRESERVED, /* no longer reserved, but not removed yet */ WALAVAIL_REMOVED /* WAL segment has been removed */ } WALAvailability; |