diff options
author | Peter Eisentraut <peter@eisentraut.org> | 2023-10-26 09:16:25 +0200 |
---|---|---|
committer | Peter Eisentraut <peter@eisentraut.org> | 2023-10-26 09:20:54 +0200 |
commit | 611806cd726fc92989ac918eac48fd8d684869c7 (patch) | |
tree | 4ed4dc6fc9a1c5825bf42072e28312440484db28 /src/include/fe_utils/print.h | |
parent | f0efa5aec19358e2282d4968a03db1db56f0ac3f (diff) |
Add trailing commas to enum definitions
Since C99, there can be a trailing comma after the last value in an
enum definition. A lot of new code has been introducing this style on
the fly. Some new patches are now taking an inconsistent approach to
this. Some add the last comma on the fly if they add a new last
value, some are trying to preserve the existing style in each place,
some are even dropping the last comma if there was one. We could
nudge this all in a consistent direction if we just add the trailing
commas everywhere once.
I omitted a few places where there was a fixed "last" value that will
always stay last. I also skipped the header files of libpq and ecpg,
in case people want to use those with older compilers. There were
also a small number of cases where the enum type wasn't used anywhere
(but the enum values were), which ended up confusing pgindent a bit,
so I left those alone.
Discussion: https://www.postgresql.org/message-id/flat/386f8c45-c8ac-4681-8add-e3b0852c1620%40eisentraut.org
Diffstat (limited to 'src/include/fe_utils/print.h')
-rw-r--r-- | src/include/fe_utils/print.h | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/src/include/fe_utils/print.h b/src/include/fe_utils/print.h index cc6652def9e..13ebb003624 100644 --- a/src/include/fe_utils/print.h +++ b/src/include/fe_utils/print.h @@ -36,7 +36,7 @@ enum printFormat PRINT_LATEX_LONGTABLE, PRINT_TROFF_MS, PRINT_UNALIGNED, - PRINT_WRAPPED + PRINT_WRAPPED, /* add your favourite output format here ... */ }; @@ -55,7 +55,7 @@ typedef enum printTextRule PRINT_RULE_TOP, /* top horizontal line */ PRINT_RULE_MIDDLE, /* intra-data horizontal line */ PRINT_RULE_BOTTOM, /* bottom horizontal line */ - PRINT_RULE_DATA /* data line (hrule is unused here) */ + PRINT_RULE_DATA, /* data line (hrule is unused here) */ } printTextRule; typedef enum printTextLineWrap @@ -63,7 +63,7 @@ typedef enum printTextLineWrap /* Line wrapping conditions */ PRINT_LINE_WRAP_NONE, /* No wrapping */ PRINT_LINE_WRAP_WRAP, /* Wraparound due to overlength line */ - PRINT_LINE_WRAP_NEWLINE /* Newline in data */ + PRINT_LINE_WRAP_NEWLINE, /* Newline in data */ } printTextLineWrap; typedef enum printXheaderWidthType @@ -99,7 +99,7 @@ typedef struct printTextFormat typedef enum unicode_linestyle { UNICODE_LINESTYLE_SINGLE = 0, - UNICODE_LINESTYLE_DOUBLE + UNICODE_LINESTYLE_DOUBLE, } unicode_linestyle; struct separator |