Initial pgindent run with pg_bsd_indent version 2.0.

The new indent version includes numerous fixes thanks to Piotr Stefaniak.
The main changes visible in this commit are:

* Nicer formatting of function-pointer declarations.
* No longer unexpectedly removes spaces in expressions using casts,
  sizeof, or offsetof.
* No longer wants to add a space in "struct structname *varname", as
  well as some similar cases for const- or volatile-qualified pointers.
* Declarations using PG_USED_FOR_ASSERTS_ONLY are formatted more nicely.
* Fixes bug where comments following declarations were sometimes placed
  with no space separating them from the code.
* Fixes some odd decisions for comments following case labels.
* Fixes some cases where comments following code were indented to less
  than the expected column 33.

On the less good side, it now tends to put more whitespace around typedef
names that are not listed in typedefs.list.  This might encourage us to
put more effort into typedef name collection; it's not really a bug in
indent itself.

There are more changes coming after this round, having to do with comment
indentation and alignment of lines appearing within parentheses.  I wanted
to limit the size of the diffs to something that could be reviewed without
one's eyes completely glazing over, so it seemed better to split up the
changes as much as practical.

Discussion: https://postgr.es/m/E1dAmxK-0006EE-1r@gemulon.postgresql.org
Discussion: https://postgr.es/m/30527.1495162840@sss.pgh.pa.us

1 files changed, 62 insertions, 62 deletions

diff --git a/src/include/foreign/fdwapi.h b/src/include/foreign/fdwapi.h
index 6ca44f734f9..2ed7049a147 100644
--- a/src/include/foreign/fdwapi.h
+++ b/src/include/foreign/fdwapi.h
@@ -25,87 +25,87 @@ struct ExplainState;
  */
 
 typedef void (*GetForeignRelSize_function) (PlannerInfo *root,
-														RelOptInfo *baserel,
-														Oid foreigntableid);
+											RelOptInfo *baserel,
+											Oid foreigntableid);
 
 typedef void (*GetForeignPaths_function) (PlannerInfo *root,
-													  RelOptInfo *baserel,
-													  Oid foreigntableid);
+										  RelOptInfo *baserel,
+										  Oid foreigntableid);
 
 typedef ForeignScan *(*GetForeignPlan_function) (PlannerInfo *root,
-														 RelOptInfo *baserel,
-														  Oid foreigntableid,
-													  ForeignPath *best_path,
-															 List *tlist,
-														  List *scan_clauses,
-														   Plan *outer_plan);
+												 RelOptInfo *baserel,
+												 Oid foreigntableid,
+												 ForeignPath *best_path,
+												 List *tlist,
+												 List *scan_clauses,
+												 Plan *outer_plan);
 
 typedef void (*BeginForeignScan_function) (ForeignScanState *node,
-													   int eflags);
+										   int eflags);
 
 typedef TupleTableSlot *(*IterateForeignScan_function) (ForeignScanState *node);
 
 typedef bool (*RecheckForeignScan_function) (ForeignScanState *node,
-													   TupleTableSlot *slot);
+											 TupleTableSlot *slot);
 
 typedef void (*ReScanForeignScan_function) (ForeignScanState *node);
 
 typedef void (*EndForeignScan_function) (ForeignScanState *node);
 
 typedef void (*GetForeignJoinPaths_function) (PlannerInfo *root,
-														  RelOptInfo *joinrel,
-														RelOptInfo *outerrel,
-														RelOptInfo *innerrel,
-														  JoinType jointype,
-												   JoinPathExtraData *extra);
+											  RelOptInfo *joinrel,
+											  RelOptInfo *outerrel,
+											  RelOptInfo *innerrel,
+											  JoinType jointype,
+											  JoinPathExtraData *extra);
 
 typedef void (*GetForeignUpperPaths_function) (PlannerInfo *root,
-													 UpperRelationKind stage,
-													   RelOptInfo *input_rel,
-													 RelOptInfo *output_rel);
+											   UpperRelationKind stage,
+											   RelOptInfo *input_rel,
+											   RelOptInfo *output_rel);
 
 typedef void (*AddForeignUpdateTargets_function) (Query *parsetree,
-												   RangeTblEntry *target_rte,
-												   Relation target_relation);
+												  RangeTblEntry *target_rte,
+												  Relation target_relation);
 
 typedef List *(*PlanForeignModify_function) (PlannerInfo *root,
-														 ModifyTable *plan,
-														 Index resultRelation,
-														 int subplan_index);
+											 ModifyTable *plan,
+											 Index resultRelation,
+											 int subplan_index);
 
 typedef void (*BeginForeignModify_function) (ModifyTableState *mtstate,
-														 ResultRelInfo *rinfo,
-														 List *fdw_private,
-														 int subplan_index,
-														 int eflags);
+											 ResultRelInfo *rinfo,
+											 List *fdw_private,
+											 int subplan_index,
+											 int eflags);
 
 typedef TupleTableSlot *(*ExecForeignInsert_function) (EState *estate,
-														ResultRelInfo *rinfo,
-														TupleTableSlot *slot,
+													   ResultRelInfo *rinfo,
+													   TupleTableSlot *slot,
 												   TupleTableSlot *planSlot);
 
 typedef TupleTableSlot *(*ExecForeignUpdate_function) (EState *estate,
-														ResultRelInfo *rinfo,
-														TupleTableSlot *slot,
+													   ResultRelInfo *rinfo,
+													   TupleTableSlot *slot,
 												   TupleTableSlot *planSlot);
 
 typedef TupleTableSlot *(*ExecForeignDelete_function) (EState *estate,
-														ResultRelInfo *rinfo,
-														TupleTableSlot *slot,
+													   ResultRelInfo *rinfo,
+													   TupleTableSlot *slot,
 												   TupleTableSlot *planSlot);
 
 typedef void (*EndForeignModify_function) (EState *estate,
-													   ResultRelInfo *rinfo);
+										   ResultRelInfo *rinfo);
 
 typedef int (*IsForeignRelUpdatable_function) (Relation rel);
 
 typedef bool (*PlanDirectModify_function) (PlannerInfo *root,
-													   ModifyTable *plan,
-													   Index resultRelation,
-													   int subplan_index);
+										   ModifyTable *plan,
+										   Index resultRelation,
+										   int subplan_index);
 
 typedef void (*BeginDirectModify_function) (ForeignScanState *node,
-														int eflags);
+											int eflags);
 
 typedef TupleTableSlot *(*IterateDirectModify_function) (ForeignScanState *node);
 
@@ -115,46 +115,46 @@ typedef RowMarkType (*GetForeignRowMarkType_function) (RangeTblEntry *rte,
 												LockClauseStrength strength);
 
 typedef HeapTuple (*RefetchForeignRow_function) (EState *estate,
-															 ExecRowMark *erm,
-															 Datum rowid,
-															 bool *updated);
+												 ExecRowMark *erm,
+												 Datum rowid,
+												 bool *updated);
 
 typedef void (*ExplainForeignScan_function) (ForeignScanState *node,
-													struct ExplainState *es);
+											 struct ExplainState *es);
 
 typedef void (*ExplainForeignModify_function) (ModifyTableState *mtstate,
-														ResultRelInfo *rinfo,
-														   List *fdw_private,
-														   int subplan_index,
-													struct ExplainState *es);
+											   ResultRelInfo *rinfo,
+											   List *fdw_private,
+											   int subplan_index,
+											   struct ExplainState *es);
 
 typedef void (*ExplainDirectModify_function) (ForeignScanState *node,
-													struct ExplainState *es);
+											  struct ExplainState *es);
 
 typedef int (*AcquireSampleRowsFunc) (Relation relation, int elevel,
-											   HeapTuple *rows, int targrows,
-												  double *totalrows,
-												  double *totaldeadrows);
+									  HeapTuple *rows, int targrows,
+									  double *totalrows,
+									  double *totaldeadrows);
 
 typedef bool (*AnalyzeForeignTable_function) (Relation relation,
-												 AcquireSampleRowsFunc *func,
-													BlockNumber *totalpages);
+											  AcquireSampleRowsFunc *func,
+											  BlockNumber *totalpages);
 
 typedef List *(*ImportForeignSchema_function) (ImportForeignSchemaStmt *stmt,
-														   Oid serverOid);
+											   Oid serverOid);
 
 typedef Size (*EstimateDSMForeignScan_function) (ForeignScanState *node,
-													  ParallelContext *pcxt);
+												 ParallelContext *pcxt);
 typedef void (*InitializeDSMForeignScan_function) (ForeignScanState *node,
-													   ParallelContext *pcxt,
-														   void *coordinate);
+												   ParallelContext *pcxt,
+												   void *coordinate);
 typedef void (*InitializeWorkerForeignScan_function) (ForeignScanState *node,
-																shm_toc *toc,
-														   void *coordinate);
+													  shm_toc *toc,
+													  void *coordinate);
 typedef void (*ShutdownForeignScan_function) (ForeignScanState *node);
 typedef bool (*IsForeignScanParallelSafe_function) (PlannerInfo *root,
-															 RelOptInfo *rel,
-														 RangeTblEntry *rte);
+													RelOptInfo *rel,
+													RangeTblEntry *rte);
 
 /*
  * FdwRoutine is the struct returned by a foreign-data wrapper's handler