diff options
| author | Etsuro Fujita <efujita@postgresql.org> | 2022-12-08 16:15:00 +0900 |
|---|---|---|
| committer | Etsuro Fujita <efujita@postgresql.org> | 2022-12-08 16:15:00 +0900 |
| commit | 4b3e37993254ed098219e62ceffb1b32fac388cb (patch) | |
| tree | 0c8396fbe49ca2801e40792760f32237d7f79719 /src/include/nodes/execnodes.h | |
| parent | d3b111e3205b6e681e16b4f8e6ed01f67142ce7b (diff) | |
Remove new structure member from ResultRelInfo.
In commit ffbb7e65a, I added a ModifyTableState member to ResultRelInfo
to save the owning ModifyTableState for use by nodeModifyTable.c when
performing batch inserts, but as pointed out by Tom Lane, that changed
the array stride of es_result_relations, and that would break any
previously-compiled extension code that accesses that array. Fix by
removing that member from ResultRelInfo and instead adding a List member
at the end of EState to save such ModifyTableStates.
Per report from Tom Lane. Back-patch to v14, like the previous commit;
I chose to apply the patch to HEAD as well, to make back-patching easy.
Discussion: http://postgr.es/m/4065383.1669395453%40sss.pgh.pa.us
Diffstat (limited to 'src/include/nodes/execnodes.h')
| -rw-r--r-- | src/include/nodes/execnodes.h | 8 |
1 files changed, 3 insertions, 5 deletions
diff --git a/src/include/nodes/execnodes.h b/src/include/nodes/execnodes.h index 08ad9d6be3f..9a64a830a28 100644 --- a/src/include/nodes/execnodes.h +++ b/src/include/nodes/execnodes.h @@ -575,9 +575,6 @@ typedef struct ResultRelInfo * one of its ancestors; see ExecCrossPartitionUpdateForeignKey(). */ List *ri_ancestorResultRels; - - /* for use by nodeModifyTable.c when performing batch-inserts */ - struct ModifyTableState *ri_ModifyTableState; } ResultRelInfo; /* ---------------- @@ -703,10 +700,11 @@ typedef struct EState struct JitInstrumentation *es_jit_worker_instr; /* - * The following list contains ResultRelInfos for foreign tables on which - * batch-inserts are to be executed. + * Lists of ResultRelInfos for foreign tables on which batch-inserts are + * to be executed and owning ModifyTableStates, stored in the same order. */ List *es_insert_pending_result_relations; + List *es_insert_pending_modifytables; } EState; |