Initial pgindent run with pg_bsd_indent version 2.0.

The new indent version includes numerous fixes thanks to Piotr Stefaniak.
The main changes visible in this commit are:

* Nicer formatting of function-pointer declarations.
* No longer unexpectedly removes spaces in expressions using casts,
  sizeof, or offsetof.
* No longer wants to add a space in "struct structname *varname", as
  well as some similar cases for const- or volatile-qualified pointers.
* Declarations using PG_USED_FOR_ASSERTS_ONLY are formatted more nicely.
* Fixes bug where comments following declarations were sometimes placed
  with no space separating them from the code.
* Fixes some odd decisions for comments following case labels.
* Fixes some cases where comments following code were indented to less
  than the expected column 33.

On the less good side, it now tends to put more whitespace around typedef
names that are not listed in typedefs.list.  This might encourage us to
put more effort into typedef name collection; it's not really a bug in
indent itself.

There are more changes coming after this round, having to do with comment
indentation and alignment of lines appearing within parentheses.  I wanted
to limit the size of the diffs to something that could be reviewed without
one's eyes completely glazing over, so it seemed better to split up the
changes as much as practical.

Discussion: https://postgr.es/m/E1dAmxK-0006EE-1r@gemulon.postgresql.org
Discussion: https://postgr.es/m/30527.1495162840@sss.pgh.pa.us

1 files changed, 18 insertions, 18 deletions

diff --git a/src/include/nodes/extensible.h b/src/include/nodes/extensible.h
index 0b02cc18e99..6ba7ad27a2f 100644
--- a/src/include/nodes/extensible.h
+++ b/src/include/nodes/extensible.h
@@ -62,11 +62,11 @@ typedef struct ExtensibleNodeMethods
 	const char *extnodename;
 	Size		node_size;
 	void		(*nodeCopy) (struct ExtensibleNode *newnode,
-									   const struct ExtensibleNode *oldnode);
+							 const struct ExtensibleNode *oldnode);
 	bool		(*nodeEqual) (const struct ExtensibleNode *a,
-										  const struct ExtensibleNode *b);
+							  const struct ExtensibleNode *b);
 	void		(*nodeOut) (struct StringInfoData *str,
-										const struct ExtensibleNode *node);
+							const struct ExtensibleNode *node);
 	void		(*nodeRead) (struct ExtensibleNode *node);
 } ExtensibleNodeMethods;
 
@@ -91,12 +91,12 @@ typedef struct CustomPathMethods
 
 	/* Convert Path to a Plan */
 	struct Plan *(*PlanCustomPath) (PlannerInfo *root,
-												RelOptInfo *rel,
-												struct CustomPath *best_path,
-												List *tlist,
-												List *clauses,
-												List *custom_plans);
-}	CustomPathMethods;
+									RelOptInfo *rel,
+									struct CustomPath *best_path,
+									List *tlist,
+									List *clauses,
+									List *custom_plans);
+}			CustomPathMethods;
 
 /*
  * Custom scan.  Here again, there's not much to do: we need to be able to
@@ -120,8 +120,8 @@ typedef struct CustomExecMethods
 
 	/* Required executor methods */
 	void		(*BeginCustomScan) (CustomScanState *node,
-												EState *estate,
-												int eflags);
+									EState *estate,
+									int eflags);
 	TupleTableSlot *(*ExecCustomScan) (CustomScanState *node);
 	void		(*EndCustomScan) (CustomScanState *node);
 	void		(*ReScanCustomScan) (CustomScanState *node);
@@ -132,19 +132,19 @@ typedef struct CustomExecMethods
 
 	/* Optional methods: needed if parallel execution is supported */
 	Size		(*EstimateDSMCustomScan) (CustomScanState *node,
-													  ParallelContext *pcxt);
+										  ParallelContext *pcxt);
 	void		(*InitializeDSMCustomScan) (CustomScanState *node,
-														ParallelContext *pcxt,
-														void *coordinate);
+											ParallelContext *pcxt,
+											void *coordinate);
 	void		(*InitializeWorkerCustomScan) (CustomScanState *node,
-														   shm_toc *toc,
-														   void *coordinate);
+											   shm_toc *toc,
+											   void *coordinate);
 	void		(*ShutdownCustomScan) (CustomScanState *node);
 
 	/* Optional: print additional information in EXPLAIN */
 	void		(*ExplainCustomScan) (CustomScanState *node,
-												  List *ancestors,
-												  ExplainState *es);
+									  List *ancestors,
+									  ExplainState *es);
 } CustomExecMethods;
 
 extern void RegisterCustomScanMethods(const CustomScanMethods *methods);