diff options
| author | Tom Lane <tgl@sss.pgh.pa.us> | 2011-11-27 22:27:32 -0500 |
|---|---|---|
| committer | Tom Lane <tgl@sss.pgh.pa.us> | 2011-11-27 22:27:32 -0500 |
| commit | 0702c86a13e6c644c32cf773af0a3a76e425ec50 (patch) | |
| tree | 5ec9f1e30d78a0589f95706c835dd0682f78260c /src/include/nodes/makefuncs.h | |
| parent | bcba9acf0d56d3fd5aa37c4ba6b24b6084032e58 (diff) | |
Ensure that whole-row junk Vars are always of composite type.
The EvalPlanQual machinery assumes that whole-row Vars generated for the
outputs of non-table RTEs will be of composite types. However, for the
case where the RTE is a function call returning a scalar type, we were
doing the wrong thing, as a result of sharing code with a parser case
where the function's scalar output is wanted. (Or at least, that's what
that case has done historically; it does seem a bit inconsistent.)
To fix, extend makeWholeRowVar's API so that it can support both use-cases.
This fixes Belinda Cussen's report of crashes during concurrent execution
of UPDATEs involving joins to the result of UNNEST() --- in READ COMMITTED
mode, we'd run the EvalPlanQual machinery after a conflicting row update
commits, and it was expecting to get a HeapTuple not a scalar datum from
the "wholerowN" variable referencing the function RTE.
Back-patch to 9.0 where the current EvalPlanQual implementation appeared.
In 9.1 and up, this patch also fixes failure to attach the correct
collation to the Var generated for a scalar-result case. An example:
regression=# select upper(x.*) from textcat('ab', 'cd') x;
ERROR: could not determine which collation to use for upper() function
Diffstat (limited to 'src/include/nodes/makefuncs.h')
| -rw-r--r-- | src/include/nodes/makefuncs.h | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/src/include/nodes/makefuncs.h b/src/include/nodes/makefuncs.h index 61314608f53..812666211ef 100644 --- a/src/include/nodes/makefuncs.h +++ b/src/include/nodes/makefuncs.h @@ -35,7 +35,8 @@ extern Var *makeVarFromTargetEntry(Index varno, extern Var *makeWholeRowVar(RangeTblEntry *rte, Index varno, - Index varlevelsup); + Index varlevelsup, + bool allowScalar); extern TargetEntry *makeTargetEntry(Expr *expr, AttrNumber resno, |