diff options
| author | Amit Langote <amitlan@postgresql.org> | 2023-07-21 19:15:34 +0900 |
|---|---|---|
| committer | Amit Langote <amitlan@postgresql.org> | 2023-07-21 19:15:34 +0900 |
| commit | 7c7412cae3ea8f8accdec1022969a9360b74f253 (patch) | |
| tree | 1ce80497cc5adbe9a33723740a296de929000664 /src/include/nodes/makefuncs.h | |
| parent | 97ff8dd02ca788020021cdafb85d77d4fd3f3125 (diff) | |
Code review for commit b6e1157e7d
b6e1157e7d made some changes to enforce that
JsonValueExpr.formatted_expr is always set and is the expression that
gives a JsonValueExpr its runtime value, but that's not really
apparent from the comments about and the code manipulating
formatted_expr. This commit fixes that.
Per suggestion from Álvaro Herrera.
Discussion: https://postgr.es/m/20230718155313.3wqg6encgt32adqb%40alvherre.pgsql
Diffstat (limited to 'src/include/nodes/makefuncs.h')
| -rw-r--r-- | src/include/nodes/makefuncs.h | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/src/include/nodes/makefuncs.h b/src/include/nodes/makefuncs.h index 06d991b7257..31807030055 100644 --- a/src/include/nodes/makefuncs.h +++ b/src/include/nodes/makefuncs.h @@ -110,7 +110,8 @@ extern VacuumRelation *makeVacuumRelation(RangeVar *relation, Oid oid, List *va_ extern JsonFormat *makeJsonFormat(JsonFormatType type, JsonEncoding encoding, int location); -extern JsonValueExpr *makeJsonValueExpr(Expr *expr, JsonFormat *format); +extern JsonValueExpr *makeJsonValueExpr(Expr *raw_expr, Expr *formatted_expr, + JsonFormat *format); extern Node *makeJsonKeyValue(Node *key, Node *value); extern Node *makeJsonIsPredicate(Node *expr, JsonFormat *format, JsonValueType item_type, bool unique_keys, |