diff options
| author | Thomas Munro <tmunro@postgresql.org> | 2022-05-07 15:19:52 +1200 |
|---|---|---|
| committer | Thomas Munro <tmunro@postgresql.org> | 2022-05-07 16:47:29 +1200 |
| commit | e2f65f42555ff531c6d7c8f151526b4ef7c016f8 (patch) | |
| tree | 98c40e19efc4aa3c8670317c34261835d75f60c1 /src/include/pg_config_manual.h | |
| parent | b74e94dc27fdbb13954f230b1d1298430afa6c0c (diff) | |
Fix old-fd issues using global barriers everywhere.
Commits 4eb21763 and b74e94dc introduced a way to force every backend to
close all relation files, to fix an ancient Windows-only bug.
This commit extends that behavior to all operating systems and adds
a couple of extra barrier points, to fix a totally different class of
bug: the reuse of relfilenodes in scenarios that have no other kind of
cache invalidation to prevent file descriptor mix-ups.
In all releases, data corruption could occur when you moved a database
to another tablespace and then back again. Despite that, no back-patch
for now as the infrastructure required is too new and invasive. In
master only, since commit aa010514, it could also happen when using
CREATE DATABASE with a user-supplied OID or via pg_upgrade.
Author: Andres Freund <andres@anarazel.de>
Reviewed-by: Robert Haas <robertmhaas@gmail.com>
Reviewed-by: Thomas Munro <thomas.munro@gmail.com>
Discussion: https://postgr.es/m/20220209220004.kb3dgtn2x2k2gtdm%40alap3.anarazel.de
Diffstat (limited to 'src/include/pg_config_manual.h')
| -rw-r--r-- | src/include/pg_config_manual.h | 11 |
1 files changed, 0 insertions, 11 deletions
diff --git a/src/include/pg_config_manual.h b/src/include/pg_config_manual.h index 84ce5a4a5d7..8d2e3e3a57d 100644 --- a/src/include/pg_config_manual.h +++ b/src/include/pg_config_manual.h @@ -153,17 +153,6 @@ #endif /* - * If USE_BARRIER_SMGRRELEASE is defined, certain code paths that unlink - * directories will ask other backends to close all smgr file descriptors. - * This is enabled on Windows, because otherwise unlinked but still open files - * can prevent rmdir(containing_directory) from succeeding. On other - * platforms, it can be defined to exercise those code paths. - */ -#if defined(WIN32) -#define USE_BARRIER_SMGRRELEASE -#endif - -/* * Define this if your operating system supports link() */ #if !defined(WIN32) && !defined(__CYGWIN__) |