diff options
| author | Tom Lane <tgl@sss.pgh.pa.us> | 2019-10-13 15:48:26 -0400 |
|---|---|---|
| committer | Tom Lane <tgl@sss.pgh.pa.us> | 2019-10-13 15:48:26 -0400 |
| commit | 9abb2bfc046070b22e3be28173a0736da31cab5a (patch) | |
| tree | 436d534545df7601feb65f98c37221e68982b255 /src/include/port.h | |
| parent | f38291e927fa8c04eb772e6a17a3dd44da2b69e8 (diff) | |
In the postmaster, rely on the signal infrastructure to block signals.
POSIX sigaction(2) can be told to block a set of signals while a
signal handler executes. Make use of that instead of manually
blocking and unblocking signals in the postmaster's signal handlers.
This should save a few cycles, and it also prevents recursive
invocation of signal handlers when many signals arrive in close
succession. We have seen buildfarm failures that seem to be due to
postmaster stack overflow caused by such recursion (exacerbated by
a Linux PPC64 kernel bug).
This doesn't change anything about the way that it works on Windows.
Somebody might consider adjusting port/win32/signal.c to let it work
similarly, but I'm not in a position to do that.
For the moment, just apply to HEAD. Possibly we should consider
back-patching this, but it'd be good to let it age awhile first.
Discussion: https://postgr.es/m/14878.1570820201@sss.pgh.pa.us
Diffstat (limited to 'src/include/port.h')
| -rw-r--r-- | src/include/port.h | 5 |
1 files changed, 0 insertions, 5 deletions
diff --git a/src/include/port.h b/src/include/port.h index 30b6378ae56..10dcb5f0a61 100644 --- a/src/include/port.h +++ b/src/include/port.h @@ -525,11 +525,6 @@ extern int pg_mkdir_p(char *path, int omode); /* port/pqsignal.c */ typedef void (*pqsigfunc) (int signo); extern pqsigfunc pqsignal(int signo, pqsigfunc func); -#ifndef WIN32 -extern pqsigfunc pqsignal_no_restart(int signo, pqsigfunc func); -#else -#define pqsignal_no_restart(signo, func) pqsignal(signo, func) -#endif /* port/quotes.c */ extern char *escape_single_quotes_ascii(const char *src); |