diff options
| author | Andres Freund <andres@anarazel.de> | 2015-08-05 18:19:52 +0200 |
|---|---|---|
| committer | Andres Freund <andres@anarazel.de> | 2015-08-05 18:19:52 +0200 |
| commit | de6fd1c898f6eca82c2130a9dbb42d00da68d79e (patch) | |
| tree | 2387db94ee7d19f19ec45dbfc31c3a6c3494a62c /src/include/port/atomics/generic-gcc.h | |
| parent | a855118be3f0682a2061448db5a87dec50717af4 (diff) | |
Rely on inline functions even if that causes warnings in older compilers.
So far we have worked around the fact that some very old compilers do
not support 'inline' functions by only using inline functions
conditionally (or not at all). Since such compilers are very rare by
now, we have decided to rely on inline functions from 9.6 onwards.
To avoid breaking these old compilers inline is defined away when not
supported. That'll cause "function x defined but not used" type of
warnings, but since nobody develops on such compilers anymore that's
ok.
This change in policy will allow us to more easily employ inline
functions.
I chose to remove code previously conditional on PG_USE_INLINE as it
seemed confusing to have code dependent on a define that's always
defined.
Blacklisting of compilers, like in c53f73879f, now has to be done
differently. A platform template can define PG_FORCE_DISABLE_INLINE to
force inline to be defined empty.
Discussion: 20150701161447.GB30708@awork2.anarazel.de
Diffstat (limited to 'src/include/port/atomics/generic-gcc.h')
| -rw-r--r-- | src/include/port/atomics/generic-gcc.h | 8 |
1 files changed, 1 insertions, 7 deletions
diff --git a/src/include/port/atomics/generic-gcc.h b/src/include/port/atomics/generic-gcc.h index 591c9fe1eb3..306c38f6f7f 100644 --- a/src/include/port/atomics/generic-gcc.h +++ b/src/include/port/atomics/generic-gcc.h @@ -57,6 +57,7 @@ # define pg_write_barrier_impl() __atomic_thread_fence(__ATOMIC_RELEASE) #endif + #ifdef HAVE_ATOMICS /* generic gcc based atomic flag implementation */ @@ -103,11 +104,6 @@ typedef struct pg_atomic_uint64 #endif /* defined(HAVE_GCC__ATOMIC_INT64_CAS) || defined(HAVE_GCC__SYNC_INT64_CAS) */ -/* - * Implementation follows. Inlined or directly included from atomics.c - */ -#if defined(PG_USE_INLINE) || defined(ATOMICS_INCLUDE_DEFINITIONS) - #ifdef PG_HAVE_ATOMIC_FLAG_SUPPORT #if defined(HAVE_GCC__SYNC_CHAR_TAS) || defined(HAVE_GCC__SYNC_INT32_TAS) @@ -231,6 +227,4 @@ pg_atomic_fetch_add_u64_impl(volatile pg_atomic_uint64 *ptr, int64 add_) #endif /* !defined(PG_DISABLE_64_BIT_ATOMICS) */ -#endif /* defined(PG_USE_INLINE) || defined(ATOMICS_INCLUDE_DEFINITIONS) */ - #endif /* defined(HAVE_ATOMICS) */ |