diff options
| author | Tom Lane <tgl@sss.pgh.pa.us> | 2019-12-01 13:09:26 -0500 |
|---|---|---|
| committer | Tom Lane <tgl@sss.pgh.pa.us> | 2019-12-01 13:09:26 -0500 |
| commit | b154d70f743039452f2cadee9566d754e79e3653 (patch) | |
| tree | 12fa3e8694d50d5c091ab158199889c9e03e824d /src/include | |
| parent | 0dafed6fedf4da0e0e38c5961ae4b1540b4a8a5c (diff) | |
Fix misbehavior with expression indexes on ON COMMIT DELETE ROWS tables.
We implement ON COMMIT DELETE ROWS by truncating tables marked that
way, which requires also truncating/rebuilding their indexes. But
RelationTruncateIndexes asks the relcache for up-to-date copies of any
index expressions, which may cause execution of eval_const_expressions
on them, which can result in actual execution of subexpressions.
This is a bad thing to have happening during ON COMMIT. Manuel Rigger
reported that use of a SQL function resulted in crashes due to
expectations that ActiveSnapshot would be set, which it isn't.
The most obvious fix perhaps would be to push a snapshot during
PreCommit_on_commit_actions, but I think that would just open the door
to more problems: CommitTransaction explicitly expects that no
user-defined code can be running at this point.
Fortunately, since we know that no tuples exist to be indexed, there
seems no need to use the real index expressions or predicates during
RelationTruncateIndexes. We can set up dummy index expressions
instead (we do need something that will expose the right data type,
as there are places that build index tupdescs based on this), and
just ignore predicates and exclusion constraints.
In a green field it'd likely be better to reimplement ON COMMIT DELETE
ROWS using the same "init fork" infrastructure used for unlogged
relations. That seems impractical without catalog changes though,
and even without that it'd be too big a change to back-patch.
So for now do it like this.
Per private report from Manuel Rigger. This has been broken forever,
so back-patch to all supported branches.
Diffstat (limited to 'src/include')
| -rw-r--r-- | src/include/catalog/index.h | 2 | ||||
| -rw-r--r-- | src/include/utils/relcache.h | 1 |
2 files changed, 3 insertions, 0 deletions
diff --git a/src/include/catalog/index.h b/src/include/catalog/index.h index 1113d25b2d8..27d9e537d31 100644 --- a/src/include/catalog/index.h +++ b/src/include/catalog/index.h @@ -106,6 +106,8 @@ extern void index_drop(Oid indexId, bool concurrent, bool concurrent_lock_mode); extern IndexInfo *BuildIndexInfo(Relation index); +extern IndexInfo *BuildDummyIndexInfo(Relation index); + extern bool CompareIndexInfo(IndexInfo *info1, IndexInfo *info2, Oid *collations1, Oid *collations2, Oid *opfamilies1, Oid *opfamilies2, diff --git a/src/include/utils/relcache.h b/src/include/utils/relcache.h index d9c10ffcbaf..06ea5bc8179 100644 --- a/src/include/utils/relcache.h +++ b/src/include/utils/relcache.h @@ -48,6 +48,7 @@ extern List *RelationGetStatExtList(Relation relation); extern Oid RelationGetPrimaryKeyIndex(Relation relation); extern Oid RelationGetReplicaIndex(Relation relation); extern List *RelationGetIndexExpressions(Relation relation); +extern List *RelationGetDummyIndexExpressions(Relation relation); extern List *RelationGetIndexPredicate(Relation relation); typedef enum IndexAttrBitmapKind |