diff options
| author | Amit Kapila <akapila@postgresql.org> | 2021-02-10 07:17:09 +0530 |
|---|---|---|
| committer | Amit Kapila <akapila@postgresql.org> | 2021-02-10 07:17:09 +0530 |
| commit | cd142e032ebd50ec7974b3633269477c2c72f1cc (patch) | |
| tree | e1ad3b108bf91b5e0ad82f2455ebfec98ad83e93 /src/include | |
| parent | 31c7fb41e26bf03dae231c7165a1a16388b2e366 (diff) | |
Make pg_replication_origin_drop safe against concurrent drops.
Currently, we get the origin id from the name and then drop the origin by
taking ExclusiveLock on ReplicationOriginRelationId. So, two concurrent
sessions can get the id from the name at the same time and then when they
try to drop the origin, one of the sessions will get the either
"tuple concurrently deleted" or "cache lookup failed for replication
origin ..".
To prevent this race condition we do the entire operation under lock. This
obviates the need for replorigin_drop() API and we have removed it so if
any extension authors are using it they need to instead use
replorigin_drop_by_name. See it's usage in pg_replication_origin_drop().
Author: Peter Smith
Reviewed-by: Amit Kapila, Euler Taveira, Petr Jelinek, and Alvaro
Herrera
Discussion: https://www.postgresql.org/message-id/CAHut%2BPuW8DWV5fskkMWWMqzt-x7RPcNQOtJQBp6SdwyRghCk7A%40mail.gmail.com
Diffstat (limited to 'src/include')
| -rw-r--r-- | src/include/replication/origin.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/include/replication/origin.h b/src/include/replication/origin.h index 731445ae8f7..d2ed6305fe1 100644 --- a/src/include/replication/origin.h +++ b/src/include/replication/origin.h @@ -40,7 +40,7 @@ extern PGDLLIMPORT TimestampTz replorigin_session_origin_timestamp; /* API for querying & manipulating replication origins */ extern RepOriginId replorigin_by_name(char *name, bool missing_ok); extern RepOriginId replorigin_create(char *name); -extern void replorigin_drop(RepOriginId roident, bool nowait); +extern void replorigin_drop_by_name(char *name, bool missing_ok, bool nowait); extern bool replorigin_by_oid(RepOriginId roident, bool missing_ok, char **roname); |