diff options
| author | Tom Lane <tgl@sss.pgh.pa.us> | 2009-06-05 18:50:59 +0000 |
|---|---|---|
| committer | Tom Lane <tgl@sss.pgh.pa.us> | 2009-06-05 18:50:59 +0000 |
| commit | f5f3d1440a6f152859d601ee3c9230835d0dcc4f (patch) | |
| tree | 8f83633c72ab7c380fc190567723a40ddbbf4e86 /src/include | |
| parent | 7920e7cc7fa4bc8b95a72c251bcac56537bfa699 (diff) | |
GIN's ItemPointerIsMin, ItemPointerIsMax, and ItemPointerIsLossyPage macros
should use GinItemPointerGetBlockNumber/GinItemPointerGetOffsetNumber,
not ItemPointerGetBlockNumber/ItemPointerGetOffsetNumber, because the latter
will Assert() on ip_posid == 0, ie a "Min" pointer. (Thus, ItemPointerIsMin
has never worked at all, but it seems unused at present.) I'm not certain
that the case can occur in normal functioning, but it's blowing up on me
while investigating Tatsuo-san's data corruption problem. In any case it
seems like a problem waiting to bite someone.
Back-patch just in case this really is a problem for somebody in the field.
Diffstat (limited to 'src/include')
| -rw-r--r-- | src/include/access/gin.h | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/src/include/access/gin.h b/src/include/access/gin.h index 557ac1c79e0..ef37e6c87be 100644 --- a/src/include/access/gin.h +++ b/src/include/access/gin.h @@ -3,7 +3,7 @@ * header file for postgres inverted index access method implementation. * * Copyright (c) 2006, PostgreSQL Global Development Group - * $PostgreSQL: pgsql/src/include/access/gin.h,v 1.9.2.3 2009/03/24 22:06:32 tgl Exp $ + * $PostgreSQL: pgsql/src/include/access/gin.h,v 1.9.2.4 2009/06/05 18:50:59 tgl Exp $ *-------------------------------------------------------------------------- */ @@ -423,9 +423,9 @@ extern void newScanKey(IndexScanDesc scan); extern DLLIMPORT int GinFuzzySearchLimit; #define ItemPointerSetMax(p) ItemPointerSet( (p), (BlockNumber)0xffffffff, (OffsetNumber)0xffff ) -#define ItemPointerIsMax(p) ( ItemPointerGetBlockNumber(p) == (BlockNumber)0xffffffff && ItemPointerGetOffsetNumber(p) == (OffsetNumber)0xffff ) +#define ItemPointerIsMax(p) ( GinItemPointerGetBlockNumber(p) == (BlockNumber)0xffffffff && GinItemPointerGetOffsetNumber(p) == (OffsetNumber)0xffff ) #define ItemPointerSetMin(p) ItemPointerSet( (p), (BlockNumber)0, (OffsetNumber)0) -#define ItemPointerIsMin(p) ( ItemPointerGetBlockNumber(p) == (BlockNumber)0 && ItemPointerGetOffsetNumber(p) == (OffsetNumber)0 ) +#define ItemPointerIsMin(p) ( GinItemPointerGetBlockNumber(p) == (BlockNumber)0 && GinItemPointerGetOffsetNumber(p) == (OffsetNumber)0 ) extern Datum gingetmulti(PG_FUNCTION_ARGS); extern Datum gingettuple(PG_FUNCTION_ARGS); |