diff options
| author | Michael Meskes <meskes@postgresql.org> | 2015-02-05 15:12:34 +0100 |
|---|---|---|
| committer | Michael Meskes <meskes@postgresql.org> | 2015-08-12 13:57:57 +0200 |
| commit | a2b2565fc9318b8903ef4821bc0be40a64810aec (patch) | |
| tree | c6c4c383f71cccc8f59578223c60c21470c28475 /src/interfaces/ecpg/ecpglib/execute.c | |
| parent | 7a801ba8ce7befc2309ece2ca918eb688c67fda9 (diff) | |
This routine was calling ecpg_alloc to allocate to memory but did not
actually check the returned pointer allocated, potentially NULL which
could be the result of a malloc call.
Issue noted by Coverity, fixed by Michael Paquier <michael@otacoo.com>
Diffstat (limited to 'src/interfaces/ecpg/ecpglib/execute.c')
| -rw-r--r-- | src/interfaces/ecpg/ecpglib/execute.c | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/src/interfaces/ecpg/ecpglib/execute.c b/src/interfaces/ecpg/ecpglib/execute.c index f1b51faade5..47e203c8aa0 100644 --- a/src/interfaces/ecpg/ecpglib/execute.c +++ b/src/interfaces/ecpg/ecpglib/execute.c @@ -402,11 +402,10 @@ ecpg_store_result(const PGresult *results, int act_field, } ecpg_log("ecpg_store_result on line %d: allocating memory for %d tuples\n", stmt->lineno, ntuples); - var->value = (char *) ecpg_alloc(len, stmt->lineno); + var->value = (char *) ecpg_auto_alloc(len, stmt->lineno); if (!var->value) return false; *((char **) var->pointer) = var->value; - ecpg_add_mem(var->value, stmt->lineno); } /* allocate indicator variable if needed */ @@ -414,11 +413,10 @@ ecpg_store_result(const PGresult *results, int act_field, { int len = var->ind_offset * ntuples; - var->ind_value = (char *) ecpg_alloc(len, stmt->lineno); + var->ind_value = (char *) ecpg_auto_alloc(len, stmt->lineno); if (!var->ind_value) return false; *((char **) var->ind_pointer) = var->ind_value; - ecpg_add_mem(var->ind_value, stmt->lineno); } /* fill the variable with the tuple(s) */ |