diff options
author | Peter Eisentraut <peter@eisentraut.org> | 2022-07-03 20:11:05 +0200 |
---|---|---|
committer | Peter Eisentraut <peter@eisentraut.org> | 2022-07-03 20:11:05 +0200 |
commit | 5faef9d582012433db9ad05af27a77bd591508e1 (patch) | |
tree | f3ace999fcaf45d69c3eb8428d3afc4819316530 /src/interfaces/libpq/fe-connect.c | |
parent | 02c408e21a6e78ff246ea7a1beb4669634fa9c4c (diff) |
Remove redundant null pointer checks before PQclear and PQconninfoFree
These functions already had the free()-like behavior of handling null
pointers as a no-op. But it wasn't documented, so add it explicitly
to the documentation, too.
Discussion: https://www.postgresql.org/message-id/flat/dac5d2d0-98f5-94d9-8e69-46da2413593d%40enterprisedb.com
Diffstat (limited to 'src/interfaces/libpq/fe-connect.c')
-rw-r--r-- | src/interfaces/libpq/fe-connect.c | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/src/interfaces/libpq/fe-connect.c b/src/interfaces/libpq/fe-connect.c index 057c9da0ede..dc49387d6c5 100644 --- a/src/interfaces/libpq/fe-connect.c +++ b/src/interfaces/libpq/fe-connect.c @@ -3766,8 +3766,7 @@ keep_going: /* We will come back to here until there is } /* Something went wrong with "SHOW transaction_read_only". */ - if (res) - PQclear(res); + PQclear(res); /* Append error report to conn->errorMessage. */ appendPQExpBuffer(&conn->errorMessage, @@ -3818,8 +3817,7 @@ keep_going: /* We will come back to here until there is } /* Something went wrong with "SELECT pg_is_in_recovery()". */ - if (res) - PQclear(res); + PQclear(res); /* Append error report to conn->errorMessage. */ appendPQExpBuffer(&conn->errorMessage, |