diff options
| author | Michael Paquier <michael@paquier.xyz> | 2023-09-19 08:31:06 +0900 |
|---|---|---|
| committer | Michael Paquier <michael@paquier.xyz> | 2023-09-19 08:31:06 +0900 |
| commit | af5b3c3d1eae94e9584ad1955a20b5a7cd0083c1 (patch) | |
| tree | ee74653bb50c0134fa94ad8c2de5f37fa13bdbd7 /src/pl/plpython/expected/plpython_error.out | |
| parent | c103d073819a2189d849c0a93d51c726be524c48 (diff) | |
Fix assertion failure with PL/Python exceptions
PLy_elog() was not able to handle correctly cases where a SPI called
failed, which would fill in a DETAIL string able to trigger an
assertion. We may want to improve this infrastructure so as it is able
to provide any extra detail information provided by an error stack, but
this is left as a future improvement as it could impact existing error
stacks and any applications that depend on them. For now, the assertion
is removed and a regression test is added to cover the case of a failure
with a detail string.
This problem exists since 2bd78eb8d51c, so backpatch all the way down
with tweaks to the regression tests output added where required.
Author: Alexander Lakhin
Discussion: https://postgr.es/m/18070-ab9c171cbf4ebb0f@postgresql.org
Backpatch-through: 11
Diffstat (limited to 'src/pl/plpython/expected/plpython_error.out')
| -rw-r--r-- | src/pl/plpython/expected/plpython_error.out | 13 |
1 files changed, 13 insertions, 0 deletions
diff --git a/src/pl/plpython/expected/plpython_error.out b/src/pl/plpython/expected/plpython_error.out index 9af7ea7292d..68722b00097 100644 --- a/src/pl/plpython/expected/plpython_error.out +++ b/src/pl/plpython/expected/plpython_error.out @@ -445,3 +445,16 @@ PL/Python function "notice_outerfunc" 1 (1 row) +/* test error logged with an underlying exception that includes a detail + * string (bug #18070). + */ +CREATE FUNCTION python_error_detail() RETURNS SETOF text AS $$ + plan = plpy.prepare("SELECT to_date('xy', 'DD') d") + for row in plpy.cursor(plan): + yield row['d'] +$$ LANGUAGE plpython3u; +SELECT python_error_detail(); +ERROR: error fetching next item from iterator +DETAIL: spiexceptions.InvalidDatetimeFormat: invalid value "xy" for "DD" +CONTEXT: Traceback (most recent call last): +PL/Python function "python_error_detail" |