diff options
| author | Peter Eisentraut <peter_e@gmx.net> | 2011-03-07 22:53:32 +0200 |
|---|---|---|
| committer | Peter Eisentraut <peter_e@gmx.net> | 2011-03-07 23:47:43 +0200 |
| commit | 8f76324352986287c04832f8e6450d4d2952a030 (patch) | |
| tree | bba9b884871eec42c83fdd1dac1e0383c7e65b48 /src/pl/plpython/plpython.c | |
| parent | cfcdc99db67172d46a5e226375fa97e5c5a62267 (diff) | |
Report Python errors from iterators with PLy_elog
This improves reporting, as the error string now includes the actual
Python exception. As a side effect, this no longer sets the errcode to
ERRCODE_DATA_EXCEPTION, which might be considered a feature, as it's
not documented and not clear why iterator errors should be treated
differently.
Jan Urbański
Diffstat (limited to 'src/pl/plpython/plpython.c')
| -rw-r--r-- | src/pl/plpython/plpython.c | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/src/pl/plpython/plpython.c b/src/pl/plpython/plpython.c index 4a9e2a4f181..43d332de209 100644 --- a/src/pl/plpython/plpython.c +++ b/src/pl/plpython/plpython.c @@ -1157,9 +1157,7 @@ PLy_function_handler(FunctionCallInfo fcinfo, PLyProcedure *proc) PLy_function_delete_args(proc); if (has_error) - ereport(ERROR, - (errcode(ERRCODE_DATA_EXCEPTION), - errmsg("error fetching next item from iterator"))); + PLy_elog(ERROR, "error fetching next item from iterator"); /* Disconnect from the SPI manager before returning */ if (SPI_finish() != SPI_OK_FINISH) |