diff options
| author | Noah Misch <noah@leadboat.com> | 2020-02-05 08:26:41 -0800 |
|---|---|---|
| committer | Noah Misch <noah@leadboat.com> | 2020-02-05 08:26:44 -0800 |
| commit | 887657d183fc2afcdd97bae3cdb645cbe0b59662 (patch) | |
| tree | 881de8a980fb9a43c039df6404712078d930fe08 /src/test/perl/TestLib.pm | |
| parent | b25d47b61896b313dfa0517bc8831ae355e711cd (diff) | |
When a TAP file has non-zero exit status, retain temporary directories.
PostgresNode already retained base directories in such cases. Stop
using $SIG{__DIE__}, which is redundant with the exit status check, in
lieu of proliferating it to TestLib. Back-patch to 9.6, where commit
88802e068017bee8cea7a5502a712794e761c7b5 introduced retention on
failure.
Reviewed by Daniel Gustafsson.
Discussion: https://postgr.es/m/20200202170155.GA3264196@rfd.leadboat.com
Diffstat (limited to 'src/test/perl/TestLib.pm')
| -rw-r--r-- | src/test/perl/TestLib.pm | 9 |
1 files changed, 7 insertions, 2 deletions
diff --git a/src/test/perl/TestLib.pm b/src/test/perl/TestLib.pm index d6fe26c0369..99812657669 100644 --- a/src/test/perl/TestLib.pm +++ b/src/test/perl/TestLib.pm @@ -129,8 +129,13 @@ INIT END { - # Preserve temporary directory for this test on failure - $File::Temp::KEEP_ALL = 1 unless all_tests_passing(); + # Test files have several ways of causing prove_check to fail: + # 1. Exit with a non-zero status. + # 2. Call ok(0) or similar, indicating that a constituent test failed. + # 3. Deviate from the planned number of tests. + # + # Preserve temporary directories after (1) and after (2). + $File::Temp::KEEP_ALL = 1 unless $? == 0 && all_tests_passing(); } sub all_tests_passing |