diff options
author | Amit Kapila <akapila@postgresql.org> | 2024-02-22 11:17:00 +0530 |
---|---|---|
committer | Amit Kapila <akapila@postgresql.org> | 2024-02-22 11:17:00 +0530 |
commit | 801792e528d6cb5eeb3a70f5ceb10b15bf92f0c7 (patch) | |
tree | 9f392ba3173275c6e6bb97ad3eb42ba20c43a1b2 /src/test | |
parent | 011d60c4352c5c48c0f1a185e8a12833c22a58db (diff) |
Improve ERROR/LOG messages added by commits ddd5f4f54a and 7a424ece48.
Additionally, in slotsync.c, replace one StringInfoData variable usage
with a constant string to avoid palloc/pfree. Also, replace the inclusion
of "logical.h" with "slot.h" to prevent the exposure of unnecessary
implementation details.
Reported-by: Kyotaro Horiguchi, Masahiko Sawada
Author: Shveta Malik based on suggestions by Robert Haas and Amit Kapila
Reviewed-by: Kyotaro Horiguchi, Amit Kapila
Discussion: https://postgr.es/m/20240214.162652.773291409747353211.horikyota.ntt@gmail.com
Discussion: https://postgr.es/m/20240219.134015.1888940527023074780.horikyota.ntt@gmail.com
Discussion: https://postgr.es/m/CAD21AoCYXhDYOQDAS-rhGasC2T+tYbV=8Y18o94sB=5AxcW+yA@mail.gmail.com
Diffstat (limited to 'src/test')
-rw-r--r-- | src/test/recovery/t/040_standby_failover_slots_sync.pl | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/test/recovery/t/040_standby_failover_slots_sync.pl b/src/test/recovery/t/040_standby_failover_slots_sync.pl index 2755c3fc84b..0f2f819f53b 100644 --- a/src/test/recovery/t/040_standby_failover_slots_sync.pl +++ b/src/test/recovery/t/040_standby_failover_slots_sync.pl @@ -319,7 +319,7 @@ $standby1->reload; ($result, $stdout, $stderr) = $standby1->psql('postgres', "SELECT pg_sync_replication_slots();"); ok( $stderr =~ - /HINT: 'dbname' must be specified in "primary_conninfo"/, + /ERROR: slot synchronization requires dbname to be specified in primary_conninfo/, "cannot sync slots if dbname is not specified in primary_conninfo"); ################################################## |