diff options
| author | Michael Paquier <michael@paquier.xyz> | 2021-06-14 09:25:50 +0900 |
|---|---|---|
| committer | Michael Paquier <michael@paquier.xyz> | 2021-06-14 09:25:50 +0900 |
| commit | dbab0c07e5ba1f19a991da2d72972a8fe9a41bda (patch) | |
| tree | c7f82e991f2aec0b137d3b5e2dab9a7a1c32ad03 /src/test | |
| parent | f807e3410fdfc29ced6590c7c2afa76637e001ad (diff) | |
Remove forced toast recompression in VACUUM FULL/CLUSTER
The extra checks added by the recompression of toast data introduced in
bbe0a81 is proving to have a performance impact on VACUUM or CLUSTER
even if no recompression is done. This is more noticeable with more
toastable columns that contain non-NULL values.
Improvements could be done to make those extra checks less expensive,
but that's not material for 14 at this stage, and we are not sure either
if the code path of VACUUM FULL/CLUSTER is adapted for this job.
Per discussion with several people, including Andres Freund, Robert
Haas, Álvaro Herrera, Tom Lane and myself.
Discussion: https://postgr.es/m/20210527003144.xxqppojoiwurc2iz@alap3.anarazel.de
Diffstat (limited to 'src/test')
| -rw-r--r-- | src/test/regress/expected/compression.out | 4 | ||||
| -rw-r--r-- | src/test/regress/expected/compression_1.out | 2 | ||||
| -rw-r--r-- | src/test/regress/sql/compression.sql | 2 |
3 files changed, 4 insertions, 4 deletions
diff --git a/src/test/regress/expected/compression.out b/src/test/regress/expected/compression.out index 5c645e46500..4c997e2602f 100644 --- a/src/test/regress/expected/compression.out +++ b/src/test/regress/expected/compression.out @@ -297,7 +297,7 @@ SELECT pg_column_compression(f1) FROM cmpart2; lz4 (2 rows) ---vacuum full to recompress the data +-- VACUUM FULL does not recompress SELECT pg_column_compression(f1) FROM cmdata; pg_column_compression ----------------------- @@ -309,7 +309,7 @@ VACUUM FULL cmdata; SELECT pg_column_compression(f1) FROM cmdata; pg_column_compression ----------------------- - lz4 + pglz lz4 (2 rows) diff --git a/src/test/regress/expected/compression_1.out b/src/test/regress/expected/compression_1.out index aac96037fcf..15a23924ec7 100644 --- a/src/test/regress/expected/compression_1.out +++ b/src/test/regress/expected/compression_1.out @@ -293,7 +293,7 @@ SELECT pg_column_compression(f1) FROM cmpart2; ----------------------- (0 rows) ---vacuum full to recompress the data +-- VACUUM FULL does not recompress SELECT pg_column_compression(f1) FROM cmdata; pg_column_compression ----------------------- diff --git a/src/test/regress/sql/compression.sql b/src/test/regress/sql/compression.sql index 35557c1f7de..86332dcc510 100644 --- a/src/test/regress/sql/compression.sql +++ b/src/test/regress/sql/compression.sql @@ -126,7 +126,7 @@ INSERT INTO cmpart VALUES (repeat('123456789', 4004)); SELECT pg_column_compression(f1) FROM cmpart1; SELECT pg_column_compression(f1) FROM cmpart2; ---vacuum full to recompress the data +-- VACUUM FULL does not recompress SELECT pg_column_compression(f1) FROM cmdata; VACUUM FULL cmdata; SELECT pg_column_compression(f1) FROM cmdata; |