diff options
author | Tom Lane <tgl@sss.pgh.pa.us> | 2013-05-10 17:15:58 -0400 |
---|---|---|
committer | Tom Lane <tgl@sss.pgh.pa.us> | 2013-05-10 17:15:58 -0400 |
commit | 79e5d72f3cbbb1b337dbdc5a7e08cd3804ca9d50 (patch) | |
tree | bf8276e72ad5f247de7fdde76e10907443d6129b /src/tutorial/funcs_new.c | |
parent | a0a98837f4a42ef939544008a9270b1d82655912 (diff) |
Guard against input_rows == 0 in estimate_num_groups().
This case doesn't normally happen, because the planner usually clamps
all row estimates to at least one row; but I found that it can arise
when dealing with relations excluded by constraints. Without a defense,
estimate_num_groups() can return zero, which leads to divisions by zero
inside the planner as well as assertion failures in the executor.
An alternative fix would be to change set_dummy_rel_pathlist() to make
the size estimate for a dummy relation 1 row instead of 0, but that seemed
pretty ugly; and probably someday we'll want to drop the convention that
the minimum rowcount estimate is 1 row.
Back-patch to 8.4, as the problem can be demonstrated that far back.
Diffstat (limited to 'src/tutorial/funcs_new.c')
0 files changed, 0 insertions, 0 deletions