diff options
author | Michael Paquier <michael@paquier.xyz> | 2025-01-08 08:47:24 +0900 |
---|---|---|
committer | Michael Paquier <michael@paquier.xyz> | 2025-01-08 08:47:24 +0900 |
commit | a786cf04df767e007069e6490734b21ff6a0418e (patch) | |
tree | d3b9a9fb61ffbeb79bdbaa40596fb7870dbddc8b /src/tutorial/syscat.source | |
parent | a1d17a8947311cbee9100ceb2b1c43a8770d6d32 (diff) |
Fix memory leak in pgoutput with relation attribute map
pgoutput caches the attribute map of a relation, that is free()'d only
when validating a RelationSyncEntry. However, this code path is not
taken when calling any of the SQL functions able to do some logical
decoding, like pg_logical_slot_{get,peek}_changes(), leaking some memory
into CacheMemoryContext on repeated calls.
This is a follow-up of c9b3d4909bbf, this time for v13 and v14. The
relation attribute map is stored in a dedicated memory context, tracked
with a static variable whose state is reset with a MemoryContext reset
callback attached to PGOutputData->context. This implementation is
similar to the approach taken by cfd6cbcf9be0.
Reported-by: Masahiko Sawada
Author: Vignesh C
Reviewed-by: Hou Zhijie
Discussion: https://postgr.es/m/CAD21AoDkAhQVSukOfH3_reuF-j4EU0-HxMqU3dU+bSTxsqT14Q@mail.gmail.com
Discussion: https://postgr.es/m/CALDaNm1hewNAsZ_e6FF52a=9drmkRJxtEPrzCB6-9mkJyeBBqA@mail.gmail.com
Backpatch-through: 13
Diffstat (limited to 'src/tutorial/syscat.source')
0 files changed, 0 insertions, 0 deletions