diff options
| author | Robert Haas <rhaas@postgresql.org> | 2015-08-04 12:58:54 -0400 |
|---|---|---|
| committer | Robert Haas <rhaas@postgresql.org> | 2015-08-04 13:05:52 -0400 |
| commit | 11ed4bab50ba6d80cc982cc4ae4675df705eda4b (patch) | |
| tree | 1b89d600e3af9dee9b2ec54a14314449ca7b11ff /src | |
| parent | bd8f768926f7eed520ba30bc135018ec24e0dd91 (diff) | |
Cap wal_buffers to avoid a server crash when it's set very large.
It must be possible to multiply wal_buffers by XLOG_BLCKSZ without
overflowing int, or calculations in StartupXLOG will go badly wrong
and crash the server. Avoid that by imposing a maximum value on
wal_buffers. This will be just under 2GB, assuming the usual value
for XLOG_BLCKSZ.
Josh Berkus, per an analysis by Andrew Gierth.
Diffstat (limited to 'src')
| -rw-r--r-- | src/backend/utils/misc/guc.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/backend/utils/misc/guc.c b/src/backend/utils/misc/guc.c index 61cde68a6c3..e710c41079c 100644 --- a/src/backend/utils/misc/guc.c +++ b/src/backend/utils/misc/guc.c @@ -2050,7 +2050,7 @@ static struct config_int ConfigureNamesInt[] = GUC_UNIT_XBLOCKS }, &XLOGbuffers, - -1, -1, INT_MAX, + -1, -1, (INT_MAX / XLOG_BLCKSZ), check_wal_buffers, NULL, NULL }, |