diff options
| author | Tom Lane <tgl@sss.pgh.pa.us> | 2010-08-18 15:22:15 +0000 |
|---|---|---|
| committer | Tom Lane <tgl@sss.pgh.pa.us> | 2010-08-18 15:22:15 +0000 |
| commit | 12bc654604e5e8cd5d71b154d19e8a7708003b8b (patch) | |
| tree | fe1e11370b7efbd4b960242ef25f890f8cc10653 /src | |
| parent | 4d20da794e6f8a28a52f888a01e622594de6c562 (diff) | |
Add missing handling of PlannedStmt.transientPlan in copyfuncs/outfuncs.
_outPlannedStmt is only debug support, so the omission there was not very
serious, but the omission in _copyPlannedStmt is a real bug. The consequence
would be that a copied plan tree would never be marked as a transient plan,
so that we would forget we ought to replan it after some not-yet-ready index
becomes ready for use. This might explain some past complaints about indexes
created with CREATE INDEX CONCURRENTLY not being used right away. Problem
spotted by Yeb Havinga.
Back-patch to 8.3, where the field was added.
Diffstat (limited to 'src')
| -rw-r--r-- | src/backend/nodes/copyfuncs.c | 3 | ||||
| -rw-r--r-- | src/backend/nodes/outfuncs.c | 3 |
2 files changed, 4 insertions, 2 deletions
diff --git a/src/backend/nodes/copyfuncs.c b/src/backend/nodes/copyfuncs.c index f6581bbe44f..b927f41e205 100644 --- a/src/backend/nodes/copyfuncs.c +++ b/src/backend/nodes/copyfuncs.c @@ -15,7 +15,7 @@ * Portions Copyright (c) 1994, Regents of the University of California * * IDENTIFICATION - * $PostgreSQL: pgsql/src/backend/nodes/copyfuncs.c,v 1.388.2.1 2009/04/16 20:42:27 tgl Exp $ + * $PostgreSQL: pgsql/src/backend/nodes/copyfuncs.c,v 1.388.2.2 2010/08/18 15:22:15 tgl Exp $ * *------------------------------------------------------------------------- */ @@ -74,6 +74,7 @@ _copyPlannedStmt(PlannedStmt *from) COPY_SCALAR_FIELD(commandType); COPY_SCALAR_FIELD(canSetTag); + COPY_SCALAR_FIELD(transientPlan); COPY_NODE_FIELD(planTree); COPY_NODE_FIELD(rtable); COPY_NODE_FIELD(resultRelations); diff --git a/src/backend/nodes/outfuncs.c b/src/backend/nodes/outfuncs.c index da069b8877c..ac0aa573bf8 100644 --- a/src/backend/nodes/outfuncs.c +++ b/src/backend/nodes/outfuncs.c @@ -8,7 +8,7 @@ * * * IDENTIFICATION - * $PostgreSQL: pgsql/src/backend/nodes/outfuncs.c,v 1.322.2.2 2009/04/16 20:42:28 tgl Exp $ + * $PostgreSQL: pgsql/src/backend/nodes/outfuncs.c,v 1.322.2.3 2010/08/18 15:22:15 tgl Exp $ * * NOTES * Every node type that can appear in stored rules' parsetrees *must* @@ -241,6 +241,7 @@ _outPlannedStmt(StringInfo str, PlannedStmt *node) WRITE_ENUM_FIELD(commandType, CmdType); WRITE_BOOL_FIELD(canSetTag); + WRITE_BOOL_FIELD(transientPlan); WRITE_NODE_FIELD(planTree); WRITE_NODE_FIELD(rtable); WRITE_NODE_FIELD(resultRelations); |