diff options
| author | Nathan Bossart <nathan@postgresql.org> | 2023-11-15 15:04:18 -0600 |
|---|---|---|
| committer | Nathan Bossart <nathan@postgresql.org> | 2023-11-15 15:04:34 -0600 |
| commit | 18f47989ecb0d63db34f8140cc335fec2543fe4a (patch) | |
| tree | 102fe4a020606d48f92ef4d48e483910ef0c00ea /src | |
| parent | 63c1b4d88a6fb268cd6cd3b177554257d6c40955 (diff) | |
Fix fallback implementation for pg_atomic_test_set_flag().
The fallback implementation of pg_atomic_test_set_flag() that uses
atomic-exchange gives pg_atomic_exchange_u32_impl() an extra
argument. This issue has been present since the introduction of
the atomics API in commit b64d92f1a5.
Reviewed-by: Andres Freund
Discussion: https://postgr.es/m/20231114035439.GA1809032%40nathanxps13
Backpatch-through: 12
Diffstat (limited to 'src')
| -rw-r--r-- | src/include/port/atomics/generic.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/include/port/atomics/generic.h b/src/include/port/atomics/generic.h index a1f245624aa..d62428acf2a 100644 --- a/src/include/port/atomics/generic.h +++ b/src/include/port/atomics/generic.h @@ -83,7 +83,7 @@ pg_atomic_init_flag_impl(volatile pg_atomic_flag *ptr) static inline bool pg_atomic_test_set_flag_impl(volatile pg_atomic_flag *ptr) { - return pg_atomic_exchange_u32_impl(ptr, &value, 1) == 0; + return pg_atomic_exchange_u32_impl(ptr, 1) == 0; } #define PG_HAVE_ATOMIC_UNLOCKED_TEST_FLAG |