diff options
| author | Tomas Vondra <tomas.vondra@postgresql.org> | 2022-08-16 23:52:10 +0200 |
|---|---|---|
| committer | Tomas Vondra <tomas.vondra@postgresql.org> | 2022-08-17 00:17:37 +0200 |
| commit | 239c3ee41be3b7c621c446344d09e3affeb8cd59 (patch) | |
| tree | 3ec0e0a94282add8b5e8443b3922d15577f1da03 /src | |
| parent | 1d968b87047708eae1d0eef27860668ec318a3ee (diff) | |
Fix assert in logicalmsg_desc
The assert, introduced by 9f1cf97bb5, is intended to check if the prefix
is terminated by a \0 byte, but it has two flaws. Firstly, prefix_size
includes the \0 byte, so prefix[prefix_size] points to the byte after
the null byte. Secondly, the check ensures the byte is not equal \0,
while it should be checking the opposite.
Backpatch-through: 14
Discussion: https://postgr.es/m/b99b6101-2f14-3796-3dfa-4a6cd7d4326d@enterprisedb.com
Diffstat (limited to 'src')
| -rw-r--r-- | src/backend/access/rmgrdesc/logicalmsgdesc.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/backend/access/rmgrdesc/logicalmsgdesc.c b/src/backend/access/rmgrdesc/logicalmsgdesc.c index d64ce2e7eff..dee440f7d99 100644 --- a/src/backend/access/rmgrdesc/logicalmsgdesc.c +++ b/src/backend/access/rmgrdesc/logicalmsgdesc.c @@ -28,7 +28,7 @@ logicalmsg_desc(StringInfo buf, XLogReaderState *record) char *message = xlrec->message + xlrec->prefix_size; char *sep = ""; - Assert(prefix[xlrec->prefix_size] != '\0'); + Assert(prefix[xlrec->prefix_size - 1] == '\0'); appendStringInfo(buf, "%s, prefix \"%s\"; payload (%zu bytes): ", xlrec->transactional ? "transactional" : "non-transactional", |