summaryrefslogtreecommitdiff
path: root/src
diff options
context:
space:
mode:
authorAndrew Dunstan <andrew@dunslane.net>2024-07-12 18:29:15 -0400
committerAndrew Dunstan <andrew@dunslane.net>2024-07-13 08:11:30 -0400
commit2423c84d098ab47ae540bc88a29bcb6fb3812e60 (patch)
tree476f85092483558b7cf5d5ff38ba7b98f6c6474f /src
parent3554d841d21624aae72c836f46af09b65b30e890 (diff)
Make sure to run pg_isready on correct port
The current code can have pg_isready unexpectedly succeed if there is a server running on the default port. To avoid this we delay running the test until after a node has been created but before it starts, and then use that node's port, so we are fairly sure there is nothing running on the port. Backpatch to all live branches.
Diffstat (limited to 'src')
-rw-r--r--src/bin/scripts/t/080_pg_isready.pl5
1 files changed, 3 insertions, 2 deletions
diff --git a/src/bin/scripts/t/080_pg_isready.pl b/src/bin/scripts/t/080_pg_isready.pl
index fc2f54f061c..558635caf2f 100644
--- a/src/bin/scripts/t/080_pg_isready.pl
+++ b/src/bin/scripts/t/080_pg_isready.pl
@@ -9,10 +9,11 @@ program_help_ok('pg_isready');
program_version_ok('pg_isready');
program_options_handling_ok('pg_isready');
-command_fails(['pg_isready'], 'fails with no server running');
-
my $node = get_new_node('main');
$node->init;
+
+$node->command_fails(['pg_isready'], 'fails with no server running');
+
$node->start;
$node->command_ok(