diff options
| author | Andres Freund <andres@anarazel.de> | 2025-11-04 18:36:18 -0500 |
|---|---|---|
| committer | Andres Freund <andres@anarazel.de> | 2025-11-04 20:03:53 -0500 |
| commit | 2d83d729d5a1a6cc5c62bf3a932fdb508ce3d1ac (patch) | |
| tree | e5172fba963c3505a5f075cff3077c048c885ce4 /src | |
| parent | d115de9d89164e87269d73d4f0f1368f06ebdd5e (diff) | |
jit: Fix accidentally-harmless type confusion
In 2a0faed9d702, which added JIT compilation support for expressions, I
accidentally used sizeof(LLVMBasicBlockRef *) instead of
sizeof(LLVMBasicBlockRef) as part of computing the size of an allocation. That
turns out to have no real negative consequences due to LLVMBasicBlockRef being
a pointer itself (and thus having the same size). It still is wrong and
confusing, so fix it.
Reported by coverity.
Backpatch-through: 13
Diffstat (limited to 'src')
| -rw-r--r-- | src/backend/jit/llvm/llvmjit_expr.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/backend/jit/llvm/llvmjit_expr.c b/src/backend/jit/llvm/llvmjit_expr.c index 712b35df7e5..ac88881e995 100644 --- a/src/backend/jit/llvm/llvmjit_expr.c +++ b/src/backend/jit/llvm/llvmjit_expr.c @@ -2505,7 +2505,7 @@ llvm_compile_expr(ExprState *state) v_nullsp = l_ptr_const(nulls, l_ptr(TypeStorageBool)); /* create blocks for checking args */ - b_checknulls = palloc(sizeof(LLVMBasicBlockRef *) * nargs); + b_checknulls = palloc(sizeof(LLVMBasicBlockRef) * nargs); for (int argno = 0; argno < nargs; argno++) { b_checknulls[argno] = |