diff options
| author | Nathan Bossart <nathan@postgresql.org> | 2023-07-28 10:07:44 -0700 |
|---|---|---|
| committer | Nathan Bossart <nathan@postgresql.org> | 2023-07-28 10:07:44 -0700 |
| commit | 6d982e3b3bd4a3a26d18639b05ca1535c260e669 (patch) | |
| tree | 67608b4aed256ad5f77fba03fc81d047e58aa566 /src | |
| parent | e055b6be7ebb0de35570102327717c99d91fe540 (diff) | |
Harmonize password reuse in vacuumdb, clusterdb, and reindexdb.
Commits 83dec5a712 and ff402ae11b taught vacuumdb to reuse
passwords instead of prompting repeatedly. However, the docs still
warn about repeated prompts, and this improvement was not applied
to clusterdb and reindexdb. This commit allows clusterdb and
reindexdb to reuse passwords just like vacuumdb does, and it
expunges the aforementioned warnings from the docs.
Reviewed-by: Gurjeet Singh, Zhang Mingli
Discussion: https://postgr.es/m/20230628045741.GA1813397%40nathanxps13
Diffstat (limited to 'src')
| -rw-r--r-- | src/bin/scripts/clusterdb.c | 2 | ||||
| -rw-r--r-- | src/bin/scripts/reindexdb.c | 2 | ||||
| -rw-r--r-- | src/fe_utils/connect_utils.c | 2 |
3 files changed, 3 insertions, 3 deletions
diff --git a/src/bin/scripts/clusterdb.c b/src/bin/scripts/clusterdb.c index 58a774013b1..65428031c74 100644 --- a/src/bin/scripts/clusterdb.c +++ b/src/bin/scripts/clusterdb.c @@ -195,7 +195,7 @@ cluster_one_database(const ConnParams *cparams, const char *table, PGconn *conn; - conn = connectDatabase(cparams, progname, echo, false, false); + conn = connectDatabase(cparams, progname, echo, false, true); initPQExpBuffer(&sql); diff --git a/src/bin/scripts/reindexdb.c b/src/bin/scripts/reindexdb.c index 5b297d1dc16..002c41f2219 100644 --- a/src/bin/scripts/reindexdb.c +++ b/src/bin/scripts/reindexdb.c @@ -315,7 +315,7 @@ reindex_one_database(ConnParams *cparams, ReindexType type, bool failed = false; int items_count = 0; - conn = connectDatabase(cparams, progname, echo, false, false); + conn = connectDatabase(cparams, progname, echo, false, true); if (concurrently && PQserverVersion(conn) < 120000) { diff --git a/src/fe_utils/connect_utils.c b/src/fe_utils/connect_utils.c index 7a1edea7c8c..7d45f5c6090 100644 --- a/src/fe_utils/connect_utils.c +++ b/src/fe_utils/connect_utils.c @@ -25,7 +25,7 @@ * * If allow_password_reuse is true, we will try to re-use any password * given during previous calls to this routine. (Callers should not pass - * allow_password_reuse=true unless reconnecting to the same database+user + * allow_password_reuse=true unless reconnecting to the same host+port+user * as before, else we might create password exposure hazards.) */ PGconn * |