diff options
author | Noah Misch <noah@leadboat.com> | 2018-04-25 18:50:29 -0700 |
---|---|---|
committer | Noah Misch <noah@leadboat.com> | 2018-04-25 18:50:34 -0700 |
commit | bb532859f45a16ae622eeebfd6e409c4481c28fa (patch) | |
tree | 54a8c80bb48f27bc376d81f56dedce3d00c24e45 /src | |
parent | 58fec95268dc925b8ae77dd50589c004b43202ba (diff) |
Correct pg_recvlogical server version test.
The predecessor test boiled down to "PQserverVersion(NULL) >= 100000",
which is always false. No release includes that, so it could not have
reintroduced CVE-2018-1058. Back-patch to 9.4, like the addition of the
predecessor in commit 8d2814f274def85f39fbe997d454b01628cb5667.
Discussion: https://postgr.es/m/20180422215551.GB2676194@rfd.leadboat.com
Diffstat (limited to 'src')
-rw-r--r-- | src/bin/pg_basebackup/streamutil.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/bin/pg_basebackup/streamutil.c b/src/bin/pg_basebackup/streamutil.c index da14c0cf585..02f008b1b01 100644 --- a/src/bin/pg_basebackup/streamutil.c +++ b/src/bin/pg_basebackup/streamutil.c @@ -212,7 +212,7 @@ GetConnection(void) * 10, so the search path cannot be changed (by us or attackers) on * earlier versions. */ - if (dbname != NULL && PQserverVersion(conn) >= 100000) + if (dbname != NULL && PQserverVersion(tmpconn) >= 100000) { PGresult *res; |