summaryrefslogtreecommitdiff
path: root/src
diff options
context:
space:
mode:
authorTom Lane <tgl@sss.pgh.pa.us>2025-03-01 14:22:56 -0500
committerTom Lane <tgl@sss.pgh.pa.us>2025-03-01 14:22:56 -0500
commitd69c781084f580c17e9acae607798469c7c2e44e (patch)
tree9806c96f0ea208e1b7e6ac116f93abc0fd6d56e4 /src
parentee78823ff5f6243a588bbeaabaa4d00c03b973e4 (diff)
Fix pg_strtof() to not crash on NULL endptr.
We had managed not to notice this simple oversight because none of our calls exercised the case --- until commit 8f427187d. That led to pg_dump crashing on any platform that uses this code (currently Cygwin and Mingw). Even though there's no immediate bug in the back branches, backpatch, because a non-POSIX-compliant strtof() substitute is trouble waiting to happen for extensions or future back-patches. Diagnosed-by: Alexander Lakhin <exclusion@gmail.com> Author: Tom Lane <tgl@sss.pgh.pa.us> Discussion: https://postgr.es/m/339b3902-4e98-4e31-a744-94e43b7b9292@gmail.com Backpatch-through: 13
Diffstat (limited to 'src')
-rw-r--r--src/port/strtof.c10
1 files changed, 7 insertions, 3 deletions
diff --git a/src/port/strtof.c b/src/port/strtof.c
index b93bafd1dfa..43d88f8f802 100644
--- a/src/port/strtof.c
+++ b/src/port/strtof.c
@@ -31,15 +31,18 @@ pg_strtof(const char *nptr, char **endptr)
{
int caller_errno = errno;
float fresult;
+ char *myendptr;
errno = 0;
- fresult = (strtof) (nptr, endptr);
+ fresult = (strtof) (nptr, &myendptr);
+ if (endptr)
+ *endptr = myendptr;
if (errno)
{
/* On error, just return the error to the caller. */
return fresult;
}
- else if ((*endptr == nptr) || isnan(fresult) ||
+ else if ((myendptr == nptr) || isnan(fresult) ||
((fresult >= FLT_MIN || fresult <= -FLT_MIN) && !isinf(fresult)))
{
/*
@@ -53,7 +56,8 @@ pg_strtof(const char *nptr, char **endptr)
else
{
/*
- * Try again. errno is already 0 here.
+ * Try again. errno is already 0 here, and we assume that the endptr
+ * won't be any different.
*/
double dresult = strtod(nptr, NULL);